Cmake updates #602
Open
Cmake updates #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dirs. Required lots of 'fixed' paths
|
Also, it requires moves-rwth/carl-storm#46 |
Closed
|
I think this supersedes #660 now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the build process significantly, mostly by cleaning up the cmake files.
The main change right now is how carl is included. It now fetches the content from a prespecified git repo at configure time. You can change the repo and the tag via the cmake options.
If you want to use the sources from an existing carl installation, you can use
-DFETCHCONTENT_SOURCE_DIR_CARL=~/carl or any other path.
This also fixes #631 by no longer copying header files to the include path.
As it uses target_sources with file_sets, this requires cmake 3.23 and thus no longer supports ubuntu 22.04.