Skip to content

Commit

Permalink
Removed TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
aittalam committed Nov 14, 2024
1 parent 38b7af5 commit 696a1b2
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions lumigator/python/mzai/backend/backend/services/jobs.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ class JobService:
# set storage path
storage_path = f"s3://{ Path(settings.S3_BUCKET) / settings.S3_JOB_RESULTS_PREFIX }/"

# TODO: we can set a different amount of GPUs per type of job
job_settings = {
JobType.INFERENCE: {
"command": settings.INFERENCE_COMMAND,
Expand Down Expand Up @@ -109,8 +108,6 @@ def _get_job_params(self, job_type: str, record, request: BaseModel) -> dict:
# get dataset S3 path from UUID
dataset_s3_path = self.data_service.get_dataset_s3_path(request.dataset)

# TODO: the following is currently both eval and inference, but
# will soon be inference only. Make sure we'll move this out
if request.model.startswith("oai://"):
model_url = settings.OAI_API_URL
elif request.model.startswith("mistral://"):
Expand Down Expand Up @@ -155,8 +152,6 @@ def _get_job_params(self, job_type: str, record, request: BaseModel) -> dict:

def create_job(self, request: JobEvalCreate | JobInferenceCreate) -> JobResponse:
"""Creates a new evaluation workload to run on Ray and returns the response status."""
# TODO: we might want to explicitly provide a job string definition as a request
# parameter, so we can reuse the same config profiles across different job types
if isinstance(request, JobEvalCreate):
job_type = JobType.EVALUATION
elif isinstance(request, JobInferenceCreate):
Expand Down

0 comments on commit 696a1b2

Please sign in to comment.