Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check tag consistency as a requirement to publishing #425

Merged
merged 4 commits into from
Dec 9, 2024

Conversation

javiermtorres
Copy link
Contributor

@javiermtorres javiermtorres commented Nov 22, 2024

What's changing

A semver tag starting with 'v' will trigger publishing to PyPI, but only if the version in the pyproject.toml files from SDK and schemas match with the git tag.

How to test it

Make a commit and git-tag it with a semver tag (e.g. v0.0.0) that does not match with the contents of the pyproject.toml files either the lumigator/python/mzai/sdk or lumigator/python/mzai/schemas directories. The publishing step should trigger but fail.

Additional notes for reviewers

Fixes #363

I already...

  • added some tests for any new functionality
  • updated the documentation
  • checked if a (backend) DB migration step was required and included it if required
    • No DB migration step required

@github-actions github-actions bot added gha GitHub actions related schemas Changes to schemas (which may be public facing) labels Nov 22, 2024
@javiermtorres javiermtorres changed the title Check consistency across git and pyproject as a requirement Check tag consistency as a requirement to publishing Nov 22, 2024
@javiermtorres javiermtorres marked this pull request as ready for review November 22, 2024 12:10
@javiermtorres javiermtorres self-assigned this Nov 25, 2024
Copy link
Member

@chainlink chainlink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one comment

@javiermtorres javiermtorres force-pushed the javiermtorres/dynamic-versions-file-change branch from e770248 to a3f7847 Compare November 29, 2024 07:57
@javiermtorres javiermtorres force-pushed the javiermtorres/dynamic-versions-file-change branch from e33f80e to 8063a8d Compare December 9, 2024 09:30
@javiermtorres javiermtorres merged commit d82ec45 into main Dec 9, 2024
9 checks passed
@javiermtorres javiermtorres deleted the javiermtorres/dynamic-versions-file-change branch December 9, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gha GitHub actions related schemas Changes to schemas (which may be public facing)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic versioning
3 participants