Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1626326 - Hide Branch/Lint/Unit from Diff Details. #29

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

arai-a
Copy link

@arai-a arai-a commented Jun 4, 2022

Just made them hidden unconditionally.

If there's a project that's using them, let me know.
I'll look into how to conditionally hide them.

@arai-a
Copy link
Author

arai-a commented Jun 4, 2022

Also made the Lint/Unit columns in the History view.
Unfortunately that part wasn't easily turned off by flag, and I just commented out.

Copy link
Collaborator

@dklawren dklawren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either something is up with my local environment, but during testing, I am not able to see the Repository Name field that normally is displayed in the Diff Detail box. When I create a new revision, with a valid diff, the Diff Detail box is empty. If I upload a new diff, then the Repository name is displayed properly. Ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants