Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

Fixed Issue #1152: Added error messaging and haptic feedback to empty UITextField #1235

Closed
wants to merge 10 commits into from

Conversation

KrisRJack
Copy link
Contributor

Fixes #1152

*** This is a build on PR #1234 ***

Added error messaging and haptic feedback when a user attempts to edit and save an empty textfield.

Testing and Review Notes

Open app. Click a login cell. In editing mode, remove all values in the username and/or password. Click save.

Screenshots

Simulator Screen Shot - iPhone 11 - 2020-05-23 at 22 29 45

To Do

  • add “WIP” to the PR title if pushing up but not complete nor ready for review
  • double check the original issue to confirm it is fully satisfied
  • add testing notes and screenshots in PR description to help guide reviewers
  • add unit tests
    • optional: consider adding integration tests (UI specs)
  • consider running this branch in the simulator and check for warnings
  • request the "UX" team perform a design review (if/when applicable)
  • make sure CI builds are passing (e.g.: fix lint and other errors)

@KrisRJack KrisRJack requested a review from a team as a code owner May 24, 2020 04:06
@KrisRJack KrisRJack changed the title Fixes Issue #1152: Added error messaging and haptic feedback to empty UITextField Fixed Issue #1152: Added error messaging and haptic feedback to empty UITextField May 24, 2020
@KrisRJack KrisRJack closed this May 24, 2020
@KrisRJack
Copy link
Contributor Author

To see this issue resolved, please refer to #1234

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit Credential: Error Messaging
1 participant