Skip to content
This repository has been archived by the owner on Jun 17, 2024. It is now read-only.

Bug 1878910: Fixes duplicate FxA sessions #5481

Closed
wants to merge 2 commits into from

Conversation

tarikeshaq
Copy link
Contributor

@tarikeshaq tarikeshaq commented Feb 6, 2024

Passes on the LOGIN web channel message to the fxa component, setting the user's session token. Also stops requesting the session scope, when singing in using email and password

NOTE: This should not land until, the following is true.. to make sure of that, I'm keeping this a draft till then

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Breaking Changes: If this is a breaking Android Components change, please push a draft PR on Reference Browser to address the breaking issues.

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-apk-{fenix,focus,klar}-debug task you're interested in.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

https://bugzilla.mozilla.org/show_bug.cgi?id=1878910

@github-actions github-actions bot added the work in progress Not ready to land yet. Work in progress (WIP). label Feb 6, 2024
@gabrielluong gabrielluong added the followup PR that needs to be followed up label Mar 15, 2024
@tarikeshaq
Copy link
Contributor Author

Will migrate this patch to Phab :)

@tarikeshaq tarikeshaq closed this Mar 21, 2024
@tarikeshaq tarikeshaq deleted the 1878910 branch March 21, 2024 18:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
followup PR that needs to be followed up work in progress Not ready to land yet. Work in progress (WIP).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants