Bugfix FXIOS-10560 - Password Generator: Keyboard Closing After Acces…

…sing Pass Gen (backport #23305) (#23382)

Bugfix FXIOS-10560 - Password Generator: Keyboard Closing After Accessing Pass Gen (#23305)

* Keyboard dismissal bug fix

* Completed ticket

* swiftlint changes

* Addressed comments

(cherry picked from commit 4d19dac)

Co-authored-by: Daniel Dervishi <[email protected]>

BrowserKit/Sources/Common/Logger/LoggerCategory.swift

@@ -65,4 +65,7 @@ public enum LoggerCategory: String {
 
     /// Remote settings
     case remoteSettings
+
+    /// Password Generator
+    case passwordGenerator
 }

firefox-ios/Client/Frontend/PasswordGenerator/PasswordGeneratorMiddleware.swift

@@ -95,16 +95,29 @@ final class PasswordGeneratorMiddleware {
 
     private func userTappedUsePassword(frame: WKFrameInfo, password: String) {
         passwordGeneratorTelemetry.usePasswordButtonPressed()
-        let jsFunctionCall = "window.__firefox__.logins.fillGeneratedPassword(\"\(password)\")"
-        frame.webView?.evaluateJavascriptInDefaultContentWorld(jsFunctionCall, frame) { (result, error) in
-            if error != nil {
-                self.logger.log("Error filling in password info",
-                                level: .warning,
-                                category: .webview)
+        if let escapedPassword = escapeString(string: password) {
+            let jsFunctionCall = "window.__firefox__.logins.fillGeneratedPassword(\(escapedPassword))"
+            frame.webView?.evaluateJavascriptInDefaultContentWorld(jsFunctionCall, frame) { (result, error) in
+                if error != nil {
+                    self.logger.log("Error filling in password info",
+                                    level: .warning,
+                                    category: .passwordGenerator)
+                }
             }
         }
     }
 
+    private func escapeString(string: String) -> String? {
+        guard let jsonData = try? JSONEncoder().encode(string),
+              let jsonString = String(data: jsonData, encoding: .utf8) else {
+            self.logger.log("Error encoding generated password to JSON",
+                            level: .warning,
+                            category: .passwordGenerator)
+            return nil
+        }
+        return jsonString
+    }
+
     private func userTappedRefreshPassword(frame: WKFrameInfo, windowUUID: WindowUUID) {
         guard let origin = frame.webView?.url?.origin else {return}
         generateNewPassword(frame: frame, completion: { generatedPassword in

firefox-ios/Client/Frontend/PasswordGenerator/PasswordGeneratorViewController.swift

@@ -234,5 +234,7 @@ class PasswordGeneratorViewController: UIViewController, StoreSubscriber, Themea
 }
 
 extension PasswordGeneratorViewController: BottomSheetChild {
-    func willDismiss() { currentTab.webView?.accessoryView.reloadViewFor(.standard)}
+    func willDismiss() {
+        LoginsHelper.yieldFocusBackToField(with: currentTab)
+    }
 }

firefox-ios/Client/Frontend/UserContent/UserScripts/AllFrames/AtDocumentStart/LoginsHelper.js

@@ -468,11 +468,13 @@ window.__firefox__.includeOnce("LoginsHelper", function() {
   };
 
   function fillGeneratedPassword(password) {
+    LoginManagerContent.fromFill = true
     this.yieldFocusBackToField();
     const passwordField = LoginManagerContent.activeField;
     passwordField?.setUserInput(password);
     const confirmationField = Logic.findConfirmationField(passwordField, LoginFormFactory);
     confirmationField?.setUserInput(password);
+    LoginManagerContent.fromFill = false
   }
 
   function yieldFocusBackToField() {
@@ -499,7 +501,7 @@ window.__firefox__.includeOnce("LoginsHelper", function() {
     const isPasswordField = field === password;
     const isYieldingFocus = LoginManagerContent.activeField === field;
     LoginManagerContent.activeField = field;
-    if (formHasNewPassword && isPasswordField && !isYieldingFocus) {
+    if (formHasNewPassword && isPasswordField && !LoginManagerContent.fromFill) {
       webkit.messageHandlers.loginsManagerMessageHandler.postMessage({
         type: "generatePassword",
       });