Refactor [v124] fix warnings + lower threshold (#18613)

* Fix standard image identifiers warnings * Remove unused variable + fix indentation * Lower warnings threshold * Fix tests warnings * Lower warning threshold again * Oups
mozilla-mobile · Feb 7, 2024 · 5afe277 · 5afe277
1 parent b4d817e
commit 5afe277
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 10 deletions.
diff --git a/BrowserKit/Sources/Common/Constants/StandardImageIndentifiers.swift b/BrowserKit/Sources/Common/Constants/StandardImageIndentifiers.swift
@@ -66,8 +66,8 @@ public struct StandardImageIdentifiers {
         public static let login = "loginLarge"
         public static let logoFirefox = "logoFirefoxLarge"
         public static let nightMode = "nightModeLarge"
-        public static let notificationDotFill = "notificationDotFillLarge"
         public static let notificationDot = "notificationDotLarge"
+        public static let notificationDotFill = "notificationDotFillLarge"
         public static let packaging = "packagingLarge"
         public static let pageZoom = "pageZoomLarge"
         public static let pin = "pinLarge"

diff --git a/firefox-ios/Client/Frontend/Browser/MetadataParserHelper.swift b/firefox-ios/Client/Frontend/Browser/MetadataParserHelper.swift
@@ -31,11 +31,10 @@ class MetadataParserHelper: TabEventHandler {
             }
 
             guard let dict = result as? [String: Any],
-                let pageURL = tab.url?.displayURL,
-                let pageMetadata = PageMetadata.fromDictionary(dict) else {
-                    TabEvent.post(.pageMetadataNotAvailable, for: tab)
-                    tab.pageMetadata = nil
-                    return
+                  let pageMetadata = PageMetadata.fromDictionary(dict) else {
+                TabEvent.post(.pageMetadataNotAvailable, for: tab)
+                tab.pageMetadata = nil
+                return
             }
 
             tab.pageMetadata = pageMetadata

diff --git a/firefox-ios/firefox-ios-tests/Tests/ClientTests/DefaultThemeManagerTests.swift b/firefox-ios/firefox-ios-tests/Tests/ClientTests/DefaultThemeManagerTests.swift
@@ -35,7 +35,7 @@ final class DefaultThemeManagerTests: XCTestCase {
     }
 
     func test_sutInitializesWithExpectedRegisteredValues() {
-        let sut = createSubject(with: userDefaults)
+        _ = createSubject(with: userDefaults)
         let expectedSystemResult = true
         let expectedNightModeResult = NSNumber(value: false)
         let expectedPrivateModeResult = false

diff --git a/firefox-ios/firefox-ios-tests/Tests/ClientTests/Library/HistoryPanelTests.swift b/firefox-ios/firefox-ios-tests/Tests/ClientTests/Library/HistoryPanelTests.swift
@@ -88,7 +88,6 @@ class HistoryPanelTests: XCTestCase {
 
     private func createSubject() -> HistoryPanel {
         let profile = MockProfile()
-        let tabManager = MockTabManager()
         let subject = HistoryPanel(profile: profile)
         trackForMemoryLeaks(subject)
         return subject

diff --git a/test-fixtures/generate-metrics.sh b/test-fixtures/generate-metrics.sh
@@ -4,8 +4,8 @@ set -e
 
 BUILD_LOG_FILE="$1"
 TYPE_LOG_FILE="$2"
-THRESHOLD_UNIT_TEST=20
-THRESHOLD_XCUITEST=20
+THRESHOLD_UNIT_TEST=15
+THRESHOLD_XCUITEST=15
 
 WARNING_COUNT=$(grep -E -v "SourcePackages/checkouts" "$BUILD_LOG_FILE" | grep -E "(^|:)[0-9]+:[0-9]+:|warning:|ld: warning:|<unknown>:0: warning:|fatal|===" | uniq | wc -l)