Bugfix FXIOS-10442 ⁃ [Menu] Fix UI issues for the profile icon on the…

… menu (#22930) * FXIOS-10442 #22855 ⁃ [Menu Redesign] Fix UI issues for the profile icon on the menu * Update firefox-ios/Client/Frontend/Strings.swift --------- Co-authored-by: roux g. buciu <[email protected]> (cherry picked from commit 53c4325)
mozilla-mobile · Nov 6, 2024 · 62e8b1d · 62e8b1d
1 parent 08a30d7
commit 62e8b1d
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 5 deletions.
diff --git a/BrowserKit/Sources/ComponentLibrary/Headers/HeaderView.swift b/BrowserKit/Sources/ComponentLibrary/Headers/HeaderView.swift
@@ -12,7 +12,7 @@ public final class HeaderView: UIView, ThemeApplicable {
         static let siteDomainLabelsVerticalSpacing: CGFloat = 12
         static let largeFaviconImageSize: CGFloat = 48
         static let favIconImageSize: CGFloat = 32
-        static let smallFaviconImageSize: CGFloat = 20
+        static let smallFaviconImageSize: CGFloat = 24
         static let maskFaviconImageSize: CGFloat = 32
         static let horizontalMargin: CGFloat = 16
         static let headerLabelDistance: CGFloat = 2
@@ -90,10 +90,12 @@ public final class HeaderView: UIView, ThemeApplicable {
         warningIconView.removeConstraints(warningIconView.constraints)
         iconMask.removeConstraints(iconMask.constraints)
         viewConstraints.removeAll()
+        let favIconPadding = (UX.maskFaviconImageSize / 2) - (UX.smallFaviconImageSize / 2)
+        let favIconLeadingConstant = isWebsiteIcon ? UX.horizontalMargin : UX.horizontalMargin + favIconPadding
         viewConstraints.append(contentsOf: [
             favicon.leadingAnchor.constraint(
                 equalTo: self.leadingAnchor,
-                constant: UX.horizontalMargin
+                constant: favIconLeadingConstant
             ),
 
             headerLabelsContainer.topAnchor.constraint(
@@ -105,7 +107,7 @@ public final class HeaderView: UIView, ThemeApplicable {
                 constant: -UX.siteDomainLabelsVerticalSpacing
             ),
             headerLabelsContainer.leadingAnchor.constraint(
-                equalTo: favicon.trailingAnchor,
+                equalTo: isWebsiteIcon ? favicon.trailingAnchor : iconMask.trailingAnchor,
                 constant: UX.siteDomainLabelsVerticalSpacing
             ),
             headerLabelsContainer.trailingAnchor.constraint(

diff --git a/firefox-ios/Client/Frontend/Browser/MainMenu/MainMenuConfigurationUtility.swift b/firefox-ios/Client/Frontend/Browser/MainMenu/MainMenuConfigurationUtility.swift
@@ -389,7 +389,7 @@ struct MainMenuConfigurationUtility: Equatable {
             isEnabled: readerModeState != .unavailable,
             isActive: readerModeState == .active,
             a11yLabel: a11yLabel,
-            a11yHint: "",
+            a11yHint: readerModeState != .unavailable ? "" : .MainMenu.AccessibilityLabels.OptionDisabledHint,
             a11yId: AccessibilityIdentifiers.MainMenu.readerView,
             action: {
                 store.dispatch(
@@ -527,7 +527,7 @@ struct MainMenuConfigurationUtility: Equatable {
             isEnabled: tabInfo.readerModeIsAvailable,
             isActive: tabInfo.isInReadingList,
             a11yLabel: a11yLabel,
-            a11yHint: "",
+            a11yHint: tabInfo.readerModeIsAvailable ? "" : .MainMenu.AccessibilityLabels.OptionDisabledHint,
             a11yId: AccessibilityIdentifiers.MainMenu.saveToReadingList,
             action: {
                 store.dispatch(

diff --git a/firefox-ios/Client/Frontend/Strings.swift b/firefox-ios/Client/Frontend/Strings.swift
@@ -3895,6 +3895,14 @@ extension String {
 // MARK: - Main Menu
 extension String {
     public struct MainMenu {
+        public struct AccessibilityLabels {
+            public static let OptionDisabledHint = MZLocalizedString(
+                key: "MainMenu.AccessibilityLabels.OptionDisabled.Hint.v133",
+                tableName: "MainMenu",
+                value: "Dimmed",
+                comment: "On the main menu, the accessibility label hint for any action/option inside the menu, that is disabled. For example: 'Save to Reading List' option, from Menu, in some cases is disabled and the voice over should indicate that. 'Save To Reading List dimmed'")
+        }
+
         public struct Account {
             public static let SignedOutTitle = MZLocalizedString(
                 key: "MainMenu.Account.SignedOut.Title.v131",