Skip to content

Commit

Permalink
Bugfix FXIOS-11128 [ToS] - "Continue" is written with lowercase (#24281)
Browse files Browse the repository at this point in the history
FXIOS-11128 [Terms of service] - "Continue" is written with lowercase
  • Loading branch information
dicarobinho authored Jan 22, 2025
1 parent dee1f07 commit 6a5b26c
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ class TermsOfServiceViewController: UIViewController, Themeable {

private lazy var confirmationButton: PrimaryRoundedButton = .build { button in
let viewModel = PrimaryRoundedButtonViewModel(
title: .Onboarding.TermsOfService.AgreementButtonTitle,
title: .Onboarding.TermsOfService.AgreementButtonTitleV2,
a11yIdentifier: AccessibilityIdentifiers.TermsOfService.agreeAndContinueButton)
button.configure(viewModel: viewModel)
button.addTarget(self, action: #selector(self.acceptTermsOfService), for: .touchUpInside)
Expand Down
11 changes: 8 additions & 3 deletions firefox-ios/Shared/Strings.swift
Original file line number Diff line number Diff line change
Expand Up @@ -1664,10 +1664,10 @@ extension String {
tableName: "Onboarding",
value: "Fast and secure web browsing",
comment: "Subtitle for the Terms of Service screen in the onboarding process.")
public static let AgreementButtonTitle = MZLocalizedString(
key: "Onboarding.TermsOfService.AgreementButtonTitle.v135",
public static let AgreementButtonTitleV2 = MZLocalizedString(
key: "Onboarding.TermsOfService.AgreementButtonTitle.v136",
tableName: "Onboarding",
value: "Agree and continue",
value: "Agree and Continue",
comment: "Title for the confirmation button for Terms of Service agreement, in the Terms of Service screen.")
public static let TermsOfServiceAgreement = MZLocalizedString(
key: "Onboarding.TermsOfService.TermsOfServiceAgreement.v135",
Expand Down Expand Up @@ -7694,6 +7694,11 @@ extension String {
tableName: "Settings",
value: "Crash reports allow us diagnose and fix issues with the browser.",
comment: "On the Settings screen, this is the subtitle text for a toggle which controls automatically sending crash reports.")
public static let AgreementButtonTitle = MZLocalizedString(
key: "Onboarding.TermsOfService.AgreementButtonTitle.v135",
tableName: "Onboarding",
value: "Agree and continue",
comment: "Title for the confirmation button for Terms of Service agreement, in the Terms of Service screen.")
}
}
}
Expand Down

0 comments on commit 6a5b26c

Please sign in to comment.