Bugfix FXIOS-8456 [v124] Fix for retain cycle between UI kit referenc…

…es in SecondaryButton (#18751)
mozilla-mobile · Feb 19, 2024 · 97d0973 · 97d0973
1 parent e05b407
commit 97d0973
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/BrowserKit/Sources/ComponentLibrary/Buttons/SecondaryRoundedButton.swift b/BrowserKit/Sources/ComponentLibrary/Buttons/SecondaryRoundedButton.swift
@@ -48,16 +48,17 @@ public class SecondaryRoundedButton: ResizableButton, ThemeApplicable {
         }
         updatedConfiguration.baseForegroundColor = foregroundColor
 
-        updatedConfiguration.titleTextAttributesTransformer = UIConfigurationTextAttributesTransformer { incoming in
+        let transformer = UIConfigurationTextAttributesTransformer { [weak foregroundColor] incoming in
             var container = incoming
 
-            container.foregroundColor = updatedConfiguration.baseForegroundColor
+            container.foregroundColor = foregroundColor
             container.font = DefaultDynamicFontHelper.preferredBoldFont(
                 withTextStyle: .callout,
                 size: UX.buttonFontSize
             )
             return container
         }
+        updatedConfiguration.titleTextAttributesTransformer = transformer
 
         configuration = updatedConfiguration
     }