Skip to content

Commit

Permalink
Create L10nSnapshotTests test plan. Enable test retries.
Browse files Browse the repository at this point in the history
  • Loading branch information
clarmso committed Jan 22, 2025
1 parent 9a554a1 commit c2ab494
Show file tree
Hide file tree
Showing 3 changed files with 43 additions and 1 deletion.
9 changes: 9 additions & 0 deletions firefox-ios/Client.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -667,6 +667,7 @@
74F80D342A0A52D700013C3D /* PrivacyPolicyViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 74F80D332A0A52D700013C3D /* PrivacyPolicyViewController.swift */; };
781C19CF2A780BEC0000DF46 /* Common in Frameworks */ = {isa = PBXBuildFile; productRef = 781C19CE2A780BEC0000DF46 /* Common */; };
787EDD852943EE75002B93AE /* JumpBackInTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 787EDD832943EE75002B93AE /* JumpBackInTests.swift */; };
78CD8C9C2D40BDBD00CA1BBF /* L10nSnapshotTests.xctestplan in Resources */ = {isa = PBXBuildFile; fileRef = 78CD8C9B2D40BDBD00CA1BBF /* L10nSnapshotTests.xctestplan */; };
78F28FC02CB81FDF00DA862E /* InactiveTabsTest.swift in Sources */ = {isa = PBXBuildFile; fileRef = 78F28FBF2CB81FDF00DA862E /* InactiveTabsTest.swift */; };
78FE1E892B040E7000338465 /* FirefoxSuggestTest.swift in Sources */ = {isa = PBXBuildFile; fileRef = 78FE1E872B040E7000338465 /* FirefoxSuggestTest.swift */; };
7AC7E0502C160FF800051D4D /* ReaderPanelEmptyStateView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 7AC7E04F2C160FF800051D4D /* ReaderPanelEmptyStateView.swift */; };
Expand Down Expand Up @@ -7358,6 +7359,9 @@
78784AF7A74084713651DC6D /* hsb */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = hsb; path = hsb.lproj/ClearPrivateDataConfirm.strings; sourceTree = "<group>"; };
787EDD832943EE75002B93AE /* JumpBackInTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = JumpBackInTests.swift; sourceTree = "<group>"; };
78CD409D8D95F94C1738A444 /* sq */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = sq; path = sq.lproj/HistoryPanel.strings; sourceTree = "<group>"; };
78CD8C982D40BD4700CA1BBF /* L10nSnapshotTests.xctestplan */ = {isa = PBXFileReference; lastKnownFileType = text; name = L10nSnapshotTests.xctestplan; path = "firefox-ios-tests/Tests/L10nSnapshotTests.xctestplan"; sourceTree = SOURCE_ROOT; };
78CD8C992D40BD8100CA1BBF /* TestPlan.xctestplan */ = {isa = PBXFileReference; lastKnownFileType = text; path = TestPlan.xctestplan; sourceTree = SOURCE_ROOT; };
78CD8C9B2D40BDBD00CA1BBF /* L10nSnapshotTests.xctestplan */ = {isa = PBXFileReference; lastKnownFileType = text; path = L10nSnapshotTests.xctestplan; sourceTree = "<group>"; };
78F28FBF2CB81FDF00DA862E /* InactiveTabsTest.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = InactiveTabsTest.swift; sourceTree = "<group>"; };
78FE1E872B040E7000338465 /* FirefoxSuggestTest.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = FirefoxSuggestTest.swift; sourceTree = "<group>"; xcLanguageSpecificationIdentifier = xcode.lang.swift; };
797548C8B7F6A801A090D219 /* id */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = id; path = id.lproj/ClearHistoryConfirm.strings; sourceTree = "<group>"; };
Expand Down Expand Up @@ -11255,6 +11259,7 @@
7B3632D21C2983F000D12AF9 /* L10nSnapshotTests */ = {
isa = PBXGroup;
children = (
78CD8C982D40BD4700CA1BBF /* L10nSnapshotTests.xctestplan */,
E40AFC641DD0F25500DA5651 /* L10nBaseSnapshotTests.swift */,
D437C4FC25FF5A3E00316F2C /* L10nMktSuiteSnapshotTests.swift */,
E40AFC531DD0E93300DA5651 /* L10nPermissionStringsSnapshotTests.swift */,
Expand Down Expand Up @@ -13684,6 +13689,8 @@
E15A8B2B286CFD48004BB2B8 /* Tests */ = {
isa = PBXGroup;
children = (
78CD8C9B2D40BDBD00CA1BBF /* L10nSnapshotTests.xctestplan */,
78CD8C992D40BD8100CA1BBF /* TestPlan.xctestplan */,
2FA4360B1ABB83B4008031D1 /* AccountTests */,
F84B21D61A090F8100AAB793 /* ClientTests */,
EAF79C172A6F0B9500251CA4 /* ExperimentIntegrationTests.xctestplan */,
Expand Down Expand Up @@ -15640,7 +15647,9 @@
D0FCF8061FE4772D004A7995 /* AllFramesAtDocumentEnd.js in Resources */,
D37524871C6E8B5A00A5F6C2 /* topdomains.txt in Resources */,
8ABE9F1E2CB462CA0080E1DF /* RemoteSettingsFetchConfig.json in Resources */,
78CD8C9A2D40BD8100CA1BBF /* TestPlan.xctestplan in Resources */,
1D91C1872CF11EA500B24960 /* disconnect-block-cookies-advertising.json in Resources */,
78CD8C9C2D40BDBD00CA1BBF /* L10nSnapshotTests.xctestplan in Resources */,
1D91C1842CF11EA500B24960 /* disconnect-block-cryptomining.json in Resources */,
39F4C0FA2045D87400746155 /* FocusHelper.js in Resources */,
E1AF3562286DE5F800960045 /* Smoketest2.xctestplan in Resources */,
Expand Down
32 changes: 32 additions & 0 deletions firefox-ios/firefox-ios-tests/Tests/L10nSnapshotTests.xctestplan
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
{
"configurations" : [
{
"id" : "E8531BAA-6B58-46CF-827B-7A30FEF28AD0",
"name" : "Configuration 1",
"options" : {

}
}
],
"defaultOptions" : {
"testRepetitionMode" : "retryOnFailure",
"testTimeoutsEnabled" : true
},
"testTargets" : [
{
"skippedTests" : [
"L10nPermissionStringsSnapshotTests",
"L10nPermissionStringsSnapshotTests\/testNSLocationWhenInUseUsageDescription()",
"ScreenGraphTest",
"ScreenGraphTest\/testSimpleToggleAction()",
"ScreenGraphTest\/testUserStateChanges()"
],
"target" : {
"containerPath" : "container:Client.xcodeproj",
"identifier" : "7BEB64401C7345600092C02E",
"name" : "L10nSnapshotTests"
}
}
],
"version" : 1
}
3 changes: 2 additions & 1 deletion firefox-ios/l10n-screenshots.sh
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@ for lang in $LOCALES; do
echo "$(date) Snapshotting $lang"
mkdir "l10n-screenshots/$lang"
fastlane snapshot --project firefox-ios/Client.xcodeproj --scheme L10nSnapshotTests \
--number_of_retries 3 \
--testPlan L10nSnapshotTests \
--number_of_retries 0 \
--skip_open_summary \
--xcargs "-maximum-parallel-testing-workers 2" \
--derived_data_path l10n-screenshots-dd \
Expand Down

0 comments on commit c2ab494

Please sign in to comment.