Skip to content

Commit

Permalink
Bugfix FXIOS-8416 [v124] Fix intermittent crash during app termination (
Browse files Browse the repository at this point in the history
#18703)

(cherry picked from commit d9566e5)

Co-authored-by: mattreaganmozilla <[email protected]>
  • Loading branch information
mergify[bot] and mattreaganmozilla authored Feb 14, 2024
1 parent 10cbec0 commit c6c56f1
Showing 1 changed file with 4 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -649,8 +649,10 @@ class BrowserCoordinator: BaseCoordinator,
guard uuid == windowUUID else { return }
// Additional cleanup performed when the current iPad window is closed.
// This is necessary in order to ensure the BVC and other memory is freed correctly.
browserViewController.contentContainer.subviews.forEach { $0.removeFromSuperview() }
browserViewController.removeFromParent()

// TODO: Revisit for [FXIOS-8064]. Disabled temporarily to avoid potential KVO crash in WebKit. (FXIOS-8416)
// browserViewController.contentContainer.subviews.forEach { $0.removeFromSuperview() }
// browserViewController.removeFromParent()
case .libraryOpened:
// Auto-close library panel if it was opened in another iPad window. [FXIOS-8095]
guard uuid != windowUUID else { return }
Expand Down

1 comment on commit c6c56f1

@firefoxci-taskcluster
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh oh! Looks like an error! Details

InterpreterError at template.tasks[0].extra[0].treeherder[1].symbol: unknown context value cron

Please sign in to comment.