Add unit test

mozilla-mobile · Jan 21, 2025 · f43dc26 · f43dc26
1 parent 50d8b58
commit f43dc26
Showing 1 changed file with 17 additions and 6 deletions.
diff --git a/...x-ios/firefox-ios-tests/Tests/ClientTests/Library/Bookmarks/BookmarksTelemetryTests.swift b/...x-ios/firefox-ios-tests/Tests/ClientTests/Library/Bookmarks/BookmarksTelemetryTests.swift
@@ -23,19 +23,19 @@ final class BookmarksTelemetryTests: XCTestCase {
         super.tearDown()
     }
 
-    func testRecordBookmark_WhenAddedFolder_ThenGleanIsCalled() throws {
-        subject?.addBookmarkFolder()
+    func testRecordBookmark_WhenAddedBookmark_ThenGleanIsCalled() throws {
+        subject?.addBookmark(eventLabel: .bookmarksPanel)
 
-        let savedMetric = try XCTUnwrap(gleanWrapper.savedEvent as? EventMetricType<NoExtras>)
-        let expectedMetricType = type(of: GleanMetrics.Bookmarks.folderAdd)
+        let savedMetric = try XCTUnwrap(gleanWrapper.savedEvent as? LabeledMetricType<CounterMetricType>)
+        let expectedMetricType = type(of: GleanMetrics.Bookmarks.add)
         let resultMetricType = type(of: savedMetric)
         let debugMessage = TelemetryDebugMessage(expectedMetric: expectedMetricType, resultMetric: resultMetricType)
         XCTAssert(resultMetricType == expectedMetricType, debugMessage.text)
-        XCTAssertEqual(gleanWrapper.recordEventNoExtraCalled, 1)
+        XCTAssertEqual(gleanWrapper.recordLabelCalled, 1)
     }
 
     func testRecordBookmark_WhenDeletedBookmark_ThenGleanIsCalled() throws {
-        subject?.deleteBookmark()
+        subject?.deleteBookmark(eventLabel: .bookmarksPanel)
 
         let savedMetric = try XCTUnwrap(gleanWrapper.savedEvent as? LabeledMetricType<CounterMetricType>)
         let expectedMetricType = type(of: GleanMetrics.Bookmarks.delete)
@@ -66,4 +66,15 @@ final class BookmarksTelemetryTests: XCTestCase {
         XCTAssert(resultMetricType == expectedMetricType, debugMessage.text)
         XCTAssertEqual(gleanWrapper.recordLabelCalled, 1)
     }
+
+    func testRecordBookmark_WhenAddedFolder_ThenGleanIsCalled() throws {
+        subject?.addBookmarkFolder()
+
+        let savedMetric = try XCTUnwrap(gleanWrapper.savedEvent as? EventMetricType<NoExtras>)
+        let expectedMetricType = type(of: GleanMetrics.Bookmarks.folderAdd)
+        let resultMetricType = type(of: savedMetric)
+        let debugMessage = TelemetryDebugMessage(expectedMetric: expectedMetricType, resultMetric: resultMetricType)
+        XCTAssert(resultMetricType == expectedMetricType, debugMessage.text)
+        XCTAssertEqual(gleanWrapper.recordEventNoExtraCalled, 1)
+    }
 }