Refactor FXIOS-7853 [v122] Redux pattern protocol improvements #17542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoanarios
approved these changes
Nov 30, 2023
Client.app: Coverage: 31.94
Redux: Coverage: 94.81
Generated by 🚫 Danger Swift against 5544ce2 |
|
@Mergifyio backport release/v121 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 5, 2023
* Add helper functions * updates * Update further places * Update tests --------- Co-authored-by: roux g. buciu <[email protected]> (cherry picked from commit b7db64a) # Conflicts: # Client/Frontend/Browser/Tabs/TabDisplayViewController.swift # Client/Frontend/Browser/Tabs/TabTrayViewController.swift # Client/Frontend/Home/HomepageViewController.swift
adudenamedruby
added a commit
that referenced
this pull request
Dec 5, 2023
…ort #17542) (#17626) * Refactor FXIOS-7853 [v122] Redux pattern protocol improvements (#17542) * Add helper functions * updates * Update further places * Update tests --------- Co-authored-by: roux g. buciu <[email protected]> (cherry picked from commit b7db64a) # Conflicts: # Client/Frontend/Browser/Tabs/TabDisplayViewController.swift # Client/Frontend/Browser/Tabs/TabTrayViewController.swift # Client/Frontend/Home/HomepageViewController.swift * Fix merge issues --------- Co-authored-by: roux g. buciu <[email protected]> Co-authored-by: Winnie Teichmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
Make subscription & unsubscription explicit!
📝 Checklist
You have to check all boxes before merging