Add MTE-2186 [v124] opt in notification fakespot test #18415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against b3ebba0 |
clarmso
approved these changes
Jan 26, 2024
isabelrios
approved these changes
Jan 29, 2024
isabelrios
reviewed
Jan 29, 2024
| @@ -66,6 +66,33 @@ class FakespotTests: IphoneOnlyTestCase { | |||
| mozWaitForElementToNotExist(app.buttons[AccessibilityIdentifiers.Toolbar.shoppingButton]) | |||
| } | |||
|
|
|||
| // https://testrail.stage.mozaws.net/index.php?/cases/view/2358924 | |||
| // Smoketest | |||
| func testAcceptTheRejectedOptInNotification() { | |||
There was a problem hiding this comment.
This test has failed 1 out of 3 in the PR, can we try to make it more stable?
~Tests/XCUITests/BaseTestCase.swift:128 - failed - Timed out waiting for element "Search Amazon" TextField to exist
There was a problem hiding this comment.
yea, i am planning to look into it, locally is hard to catch that corner case, but i will make it more stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
💡 Description
Added Accept the rejected Opt-in Notification fakespot smoke test.