Bugfix FXIOS-8309 [v122.1] System theme resetting bug #18429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
lmarceau
reviewed
Jan 29, 2024
|
It won't, because that legacy one was based off this. So this needs to be merged first, then that. :) |
|
@Mergifyio backport release/v122 release/v123 |
✅ Backports have been created
|
lmarceau
approved these changes
Jan 29, 2024
Client.app: Coverage: 32.32
CredentialProvider.appex: Coverage: 22.09
Generated by 🚫 Danger Swift against e041268 |
cyndichin
approved these changes
Jan 29, 2024
| legacyThemeManager.current = isLightTheme ? LegacyNormalTheme() : LegacyDarkTheme() | ||
| themeManager.changeCurrentTheme(isLightTheme ? .light : .dark) | ||
| themeManager.changeCurrentTheme(newTheme) |
There was a problem hiding this comment.
logic changed here in which we don't default to dark theme, are we okay with this update?
There was a problem hiding this comment.
Well, this should default to whatever's called, really, as opposed to having a random default. It's cleaner this way and the logic is easier to follow, imo.
mergify bot
pushed a commit
that referenced
this pull request
Jan 29, 2024
* fix issue * improvements because they're nice * fix mock (cherry picked from commit 43e00b7) # Conflicts: # firefox-ios/Client/Frontend/Settings/ThemeSettings/ThemeMiddleware.swift
mergify bot
pushed a commit
that referenced
this pull request
Jan 29, 2024
* fix issue * improvements because they're nice * fix mock (cherry picked from commit 43e00b7) # Conflicts: # BrowserKit/Sources/Common/Theming/DefaultThemeManager.swift # Client/Frontend/Settings/Main/General/ThemeSetting.swift # Client/Frontend/Settings/ThemeSettings/ThemeMiddleware.swift # Client/Frontend/Theme/LegacyThemeManager/LegacyThemeManager.swift # Client/Telemetry/TelemetryWrapper.swift
This was referenced Jan 29, 2024
adudenamedruby
added a commit
that referenced
this pull request
Jan 29, 2024
… (#18456) * Bugfix FXIOS-8309 [v122.1] System theme resetting bug (#18429) * fix issue * improvements because they're nice * fix mock (cherry picked from commit 43e00b7) # Conflicts: # firefox-ios/Client/Frontend/Settings/ThemeSettings/ThemeMiddleware.swift * Update ThemeMiddleware.swift --------- Co-authored-by: roux g. buciu <[email protected]>
jjSDET
pushed a commit
to jjSDET/firefox-ios
that referenced
this pull request
Feb 1, 2024
…#18429) * fix issue * improvements because they're nice * fix mock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
the migration was resetting the system theme.
Also, I started removing a bit more legacy theme stuff. Just a bit.
📝 Checklist
You have to check all boxes before merging