Add FXIOS-8314 [v124]: Removes all usages of apns in keychain #18430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarikeshaq
commented
Jan 26, 2024
Comment on lines
-74
to
-82
| NotificationCenter.default.addObserver(forName: .ProfileDidStartSyncing, object: nil, queue: .main) { _ in | ||
| let kc = MZKeychainWrapper.sharedClientAppContainerKeychain | ||
| if kc.string( | ||
| forKey: KeychainKey.apnsToken, | ||
| withAccessibility: MZKeychainItemAccessibility.afterFirstUnlock | ||
| ) == nil { | ||
| NotificationCenter.default.post(name: .RegisterForPushNotifications, object: nil) | ||
| } | ||
| } |
There was a problem hiding this comment.
this probably led to users having to update their push notification every sync because the apns token will be nil for any user who didn't migrate from the before times.
We don't need to try to re-register for push notifications every sync, there are already recovery mechanisms if a user's push subscriptions change
adudenamedruby
approved these changes
Jan 29, 2024
Client.app: Coverage: 32.32
NotificationService.appex: Coverage: 25.59
libAccount.a: Coverage: 32.2
Generated by 🚫 Danger Swift against 8d6f971 |
jjSDET
pushed a commit
to jjSDET/firefox-ios
that referenced
this pull request
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
We moved to the new push component in v116, and since then there has been no need to store the APNS token in keychain. It's also been a few releases since then and I believe it safe enough to remove the removal of the apns tokens as well, it's also inconsequential if a user upgrading from v115 to v124 keeps an old apns token in their local-only keychain.
📝 Checklist
You have to check all boxes before merging