Refactor MTE-2095 [v124] Consolidate and optimise bitrise files #18538
Conversation
Generated by 🚫 Danger Swift against 5a3d0e2 |
isabelrios
force-pushed
the
irios-consolidate-bitriseyml-files
branch
2 times, most recently
from
1296d83 to
ba1193f
Compare
isabelrios
force-pushed
the
irios-consolidate-bitriseyml-files
branch
from
ba1193f to
102ffe2
Compare
isabelrios
force-pushed
the
irios-consolidate-bitriseyml-files
branch
from
a329d4a to
43684f0
Compare
isabelrios
changed the title
| # inputs: | ||
| # - content: | | ||
| # set -euxo pipefail | ||
| # echo "$BITRISE_ARTIFACT_PATHS" |
There was a problem hiding this comment.
Is this going to need the changes similar to firefox_pull_and_unzip-dependencies?
derived_data=${BITRISE_ARTIFACT_PATHS##*|}
There was a problem hiding this comment.
No, explained in Slack, the value we get in that variable depends on the artifacts that we generate in previous stage and that are passed to next one.
Since we specify that in this line:
Line 222 in ec35137
I don't expect changes in this.
What we could do is to try to have a way to get that derived_data folder path for both app and re-use this code. But it will be easier to implement once we see both apps running I guess
adding workflows one by one copy current focus file
isabelrios
force-pushed
the
irios-consolidate-bitriseyml-files
branch
from
67ebc25 to
5a3d0e2
Compare
| # run_if: '{{getenv "BUILD_FOCUS_IOS" | eq "true"}}' | ||
| run_tests: | ||
| workflows: | ||
| - build_and_test_1_SmokeTest2: | ||
| - build_and_test_1_SmokeTest1: |
There was a problem hiding this comment.
💯 Thanks for renaming this workflow. test_1 and SmokeTest2 has been inconsistent here.
| run_if: '{{getenv "BUILD_FIREFOX_IOS" | eq "true"}}' | ||
| - build_and_test_2_SmokeTest: | ||
| - build_and_test_2_SmokeTest2: |
There was a problem hiding this comment.
Ditto. Smoketest2 instead of just Smoketest. 👍🏼
| @@ -245,7 +245,7 @@ | |||
| default = "YES"> | |||
| </TestPlanReference> | |||
| <TestPlanReference | |||
| reference = "container:firefox-ios-tests/Tests/SmokeXCUITests.xctestplan"> | |||
| reference = "container:firefox-ios-tests/Tests/Smoketest1.xctestplan"> | |||
There was a problem hiding this comment.
💯 Yes, this test plan should be called Smoketest1.
📜 Tickets
Jira ticket
Let's have an idea bout how the bitrise.yml file will look like. Using this PR to make so improvement and reduce code duplication too.
I addition to the consolidation, I'm doing some optimisations here to try to reduce the file's size
💡 Description
📝 Checklist
You have to check all boxes before merging