Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bug 1823684 [v124] Server Knobs for iOS #18609

Closed

Conversation

rosahbruno
Copy link
Contributor

📜 Tickets

Bug

💡 Description

Configure Server Knobs for iOS. Makes use of the glean.setMetricsEnabledConfig to remotely enable/disable metric collection via Nimbus experiment.

The Nimbus experiment hasn't been created yet so the API is just getting the default value of "{}", which enables/disables no metrics. Everything should just be working like before.

Testing

  1. Setting debug view tag via the GLEAN_DEBUG_VIEW_TAG
  2. Run the app and look for the topsites-impression pings. You can trigger this ping by foregrounding the app while on the new tab screen, where you can see topsites.
  3. Observe in each ping in the debug viewer that you see the top_sites.contile_advertiser metric being collected - example.
  4. Change line 110 of TelemetryWrapper.swift to glean.setMetricsEnabledConfig("{\"top_sites.contile_advertiser\": false}").
  5. Run the app again, trigger the topsites-impression ping.
  6. Observe that the metric is no longer being collected on the newer pings - example.

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed I updated documentation / comments for complex code and public methods

changelog
- adds the new `glean-server-knobs` feature to the Nimbus config
- call `setMetricsEnabledConfig` on init & pull values directly from the Nimbus experiment
@rosahbruno rosahbruno force-pushed the 1823684-server-knobs branch from e05aba3 to 05e075e Compare February 7, 2024 14:57
Copy link
Contributor

This PR has been automatically marked as stale. Please leave any comment to keep this PR opened. It will be closed automatically if no further update occurs in the next 7 days. Thank you for your contributions!

@github-actions github-actions bot added the stale Stalebot use this label to stale issues and PRs label Feb 22, 2024
@github-actions github-actions bot closed this Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Stalebot use this label to stale issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant