Add Bug 1823684 [v124] Server Knobs for iOS #18609
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Bug
💡 Description
Configure Server Knobs for iOS. Makes use of the
glean.setMetricsEnabledConfig
to remotely enable/disable metric collection via Nimbus experiment.The Nimbus experiment hasn't been created yet so the API is just getting the default value of "{}", which enables/disables no metrics. Everything should just be working like before.
Testing
topsites-impression
pings. You can trigger this ping by foregrounding the app while on the new tab screen, where you can see topsites.top_sites.contile_advertiser
metric being collected - example.TelemetryWrapper.swift
toglean.setMetricsEnabledConfig("{\"top_sites.contile_advertiser\": false}")
.📝 Checklist
You have to check all boxes before merging