Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix FXIOS-8397 [v124] App is crashing when moving a quick search engine #18619

Conversation

PARAIPAN9
Copy link
Collaborator

@PARAIPAN9 PARAIPAN9 commented Feb 7, 2024

📜 Tickets

Jira ticket
Github issue

💡 Description

  • The crash was occuring while dragging and dropping a quick search engine after the "Add Search Engine" button (this being an action that should not be permitted) causing the quick search engines array to go out of bounds..
  • This PR adds a guard statement to make sure that we remain in the same section (quickEngines) during drag&drop actions.

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed I updated documentation / comments for complex code and public methods

@PARAIPAN9 PARAIPAN9 requested a review from a team as a code owner February 7, 2024 16:09
@PARAIPAN9 PARAIPAN9 requested a review from thatswinnie February 7, 2024 16:09
@mobiletest-ci-bot
Copy link

Warnings
⚠️ Variable 'notificationDotFill' in Large is out of alphabetical order.
⚠️ Variable 'notificationDot' in Large is out of alphabetical order.
Messages
📖 Project coverage: 33.13%
📖 Edited 1 files
📖 Created 0 files

Client.app: Coverage: 31.86

File Coverage
SearchSettingsTableViewController.swift 3.01% ⚠️

Generated by 🚫 Danger Swift against edc5a86

@thatswinnie thatswinnie merged commit cac641e into main Feb 8, 2024
10 checks passed
@thatswinnie thatswinnie deleted the sparaipan/fxios-8397-App-is-crashing-when-moving-a-quick-search-engine-after-the-Add-Search-Engine-button branch February 8, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants