Add FXIOS-8087 [v124] find in page web engine #18622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattreaganmozilla
approved these changes
Feb 13, 2024
| @@ -116,6 +125,15 @@ class WKEngineSession: NSObject, | |||
| webView.engineScrollView.setContentOffset(CGPoint.zero, animated: true) | |||
| } | |||
|
|
|||
| func findInPage(text: String, function: FindInPageFunction) { | |||
| let sanitizedInput = text.replacingOccurrences(of: "\\", with: "\\\\").replacingOccurrences(of: "\"", with: "\\\"") | |||
There was a problem hiding this comment.
Just OOC is this something being brought over from the existing client? Wondering if there is a more elegant way for us to avoid how we're escaping these slashes but I'm not super-familiar with this code.
There was a problem hiding this comment.
Yeah it's brought from the existing code 🤔 It's from here exactly
Generated by 🚫 Danger Swift against 1dbaf6a |
|
Not sure what's happening here 👀
|
lmarceau
force-pushed
the
lm/FXIOS-8087-#17999-find-in-page-web-engine
branch
from
5d749fe to
1dbaf6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
Add the Find in page functionality in the
WebEngine, as it is working today in Firefox iOS.EngineSessionprotocol, as well as a new delegate. Kept this separeted from theEngineSessionDelegateso we keep smaller responsibilities.FindInPageContentScriptthat communicates with theFindInPage.jsand receive WebKit messages. Added tests for this content script.SampleBrowserapp -> This means missing images and scripts that should be injected.SampleBrowserapp to test this feature, see video for result - focus is on testing the web engine, not UI perfection :)Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-02-07.at.11.57.46.mp4
📝 Checklist
You have to check all boxes before merging