Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix MTE-2230 [v124] - Add additional matches in determine_apps_affected Bitrise workflow #18625

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

AaronMT
Copy link
Contributor

@AaronMT AaronMT commented Feb 7, 2024

https://mozilla-hub.atlassian.net/browse/MTE-2230

  • Matches identified doc root project files for building Firefox
  • If needed by Focus (TBD), we can also set Focus.

@AaronMT AaronMT requested a review from isabelrios February 7, 2024 19:28
@AaronMT AaronMT self-assigned this Feb 7, 2024
@AaronMT AaronMT requested a review from a team as a code owner February 7, 2024 19:28
@AaronMT AaronMT force-pushed the mte-2230 branch 3 times, most recently from b9fe353 to 8c5e913 Compare February 7, 2024 21:46
@mobiletest-ci-bot
Copy link

mobiletest-ci-bot commented Feb 7, 2024

Messages
📖 Edited 1 files
📖 Created 0 files

Generated by 🚫 Danger Swift against dce3bd5

Copy link
Contributor

@isabelrios isabelrios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one question to consider

bitrise.yml Outdated
if [[ "$app" == "." ]]; then
CHANGED_FILES=$(git diff --name-only $BASE_BRANCH..."$BITRISE_GIT_COMMIT")
echo "Project root changes detected: $CHANGED_FILES"
ROOT_SPECIFIC_FILES=$(echo "$CHANGED_FILES" | { grep -E '^(bootstrap\.sh|content_blocker_update\.sh|Dangerfile|Dangerfile\.swift|Info\.plist|iOSNimbusFeatureUtility\.sh|package\.lock|Package\.json|Package\.resolved|Package\.swift|rust_components_local\.sh|setup_build_tools\.sh|update_version\.sh|\.swiftlint\.yml)$' || true; })
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If only the README or a .md file is changed, what will we run? building the whole project seems to much but we may need to do a small check?

@AaronMT AaronMT force-pushed the mte-2230 branch 3 times, most recently from ec20a43 to 6a173d2 Compare February 8, 2024 19:12
@isabelrios isabelrios merged commit 74c8c8d into mozilla-mobile:main Feb 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants