Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix MTE-2449 testLaunchExternalApp for iPad #19400

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

clarmso
Copy link
Collaborator

@clarmso clarmso commented Mar 27, 2024

📜 Tickets

Jira ticket

💡 Description

Here's a patch for the PR (#19345) that the test testLaunchExternalApp() missed a case for iPad. The reminder app appears in a different index on iPad.

Now the test passes on both iPhone and iPad.

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@clarmso clarmso requested review from isabelrios and dragosb01 March 27, 2024 05:31
@clarmso clarmso requested a review from a team as a code owner March 27, 2024 05:31
@clarmso clarmso merged commit 1e8db69 into main Mar 27, 2024
7 checks passed
@clarmso clarmso deleted the cs/MTE-2449-patch-BasicBrowsing-iPad branch March 27, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants