Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix FXIOS-10392 [Menu] CFR's text is cut off: "Find what you need faster, fro..." (backport #22813) #22882

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Bugfix FXIOS-10392 [Menu] CFR's text is cut off: "Find what you need faster, fro..." (backport #22813) #22882

merged 1 commit into from
Nov 4, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 4, 2024

📜 Tickets

Jira ticket
Github issue

💡 Description

Fixed the Menu CFR for the dynamic text

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)
This is an automatic backport of pull request #22813 done by [Mergify](https://mergify.com).

@dicarobinho @mergify
Bugfix FXIOS-10392 [Menu] CFR's text is cut off (#22813)
c739fcd 
* FXIOS-10392 #22779 ⁃ [Menu Redesign] Menu CFR's text is cut off: "Find what you need faster, fro..."

* Don't show CFR for iPhones that are in landscape
Dismiss CFR on device rotation
Moved the CFR for iPads, inside the Menu, not on the top as for iPhones
Refactored some code

* Checking size class instead of userInterfaceIdiom

(cherry picked from commit c8ab224)
@mergify mergify bot requested a review from a team as a code owner November 4, 2024 16:10
@mergify mergify bot requested review from cyndichin and removed request for a team November 4, 2024 16:10
@mergify mergify bot mentioned this pull request Nov 4, 2024
Merged
6 tasks
@adudenamedruby adudenamedruby requested review from adudenamedruby and removed request for cyndichin November 4, 2024 16:12
@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 32.08%
📖 Edited 3 files
📖 Created 0 files

Client.app: Coverage: 30.63

File Coverage
ContextualHintEligibilityUtility.swift 89.43% ✅
MainMenuViewController.swift 22.35% ⚠️

ComponentLibrary: Coverage: 30.9

File Coverage
ContextualHintView.swift 0.0% ⚠️

Generated by 🚫 Danger Swift against c739fcd

@adudenamedruby adudenamedruby merged commit 3d522a5 into release/v133 Nov 4, 2024
12 of 13 checks passed
@adudenamedruby adudenamedruby deleted the mergify/bp/release/v133/pr-22813 branch November 4, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adudenamedruby adudenamedruby adudenamedruby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mobiletest-ci-bot @adudenamedruby @dicarobinho