Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate MTE-3778 - Add a new address #22894

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Automate MTE-3778 - Add a new address #22894

merged 1 commit into from
Nov 6, 2024

Conversation

dragosb01
Copy link
Collaborator

@dragosb01 dragosb01 requested a review from isabelrios November 5, 2024 10:26
@dragosb01 dragosb01 requested review from a team as code owners November 5, 2024 10:26
@mobiletest-ci-bot
Copy link

mobiletest-ci-bot commented Nov 5, 2024

Messages
📖 Edited 11 files
📖 Created 1 files

Generated by 🚫 Danger Swift against c0ee69a

Copy link
Contributor

@isabelrios isabelrios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isabelrios isabelrios requested a review from mdotb-moz November 5, 2024 11:58
Copy link
Contributor

@mdotb-moz mdotb-moz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dragosb01 Keep in mind that this PR #22842 is landed in main. This means you have to replace mozWaitForElementToExist with an array, for instance waitForElementsToExist(
[
app.collectionViews.cells.staticTexts["X"],
app.collectionViews.cells.staticTexts["Amazon"],
app.collectionViews.cells.staticTexts["Wikipedia"],
app.collectionViews.cells.staticTexts["YouTube"],
app.collectionViews.cells.staticTexts["Facebook"]
]
)

Copy link
Contributor

@mdotb-moz mdotb-moz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isabelrios isabelrios merged commit 71d03b3 into main Nov 6, 2024
10 of 11 checks passed
@isabelrios isabelrios deleted the dbigu/MTE-3778 branch November 6, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants