Add automated a11y tests #23057
Merged
Add automated a11y tests #23057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # firefox-ios/firefox-ios-tests/Tests/XCUITests/FakespotTests.swift
Client.app: Coverage: 30.16
ComponentLibrary: Coverage: 30.84
Generated by 🚫 Danger Swift against d9f160d |
clarmso
reviewed
Nov 12, 2024
| @@ -321,4 +321,42 @@ class OnboardingTests: BaseTestCase { | |||
| let topSites = app.collectionViews.cells[AccessibilityIdentifiers.FirefoxHomepage.TopSites.itemCell] | |||
| mozWaitForElementToExist(topSites) | |||
| } | |||
|
|
|||
| func testFirstRunTourAccessibility() throws { | |||
There was a problem hiding this comment.
@isabelrios Should we put such a test in TestRail and insert the TestRail link here?
There was a problem hiding this comment.
This test looks very similar to this one:
@thatswinnie are we missing something there? We can add it there so that we don't duplicate the complete test... Thanks!
There was a problem hiding this comment.
Oh never mind, just saw the call to try app.performAccessibilityAudit() we could add that in the exisiting test though...
There was a problem hiding this comment.
Discussed offline. We agreed to have this test as part of the exisiting UI testFirstRunTour. Then, the MTE team will create a specific test plan for a11y tests that can run as another workflow in parallel with the existing Smoketests and move this and other tests that will be implemented to it.
thatswinnie
had a problem deploying
to
github-pages
GitHub Actions
Failure
thatswinnie
requested review from
ih-codes
and removed request for
mdotb-moz
isabelrios
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticketGithub issue💡 Description
This adds automated a11y audits to onboarding, tab tray and overlay mode. It fixes three issues found while running the tests.
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)