Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix FXIOS-10512 #23050 ⁃ [Menu] [Accessibility] - "Tools" and "Save" headers are not announced (backport #23078) #23088

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 13, 2024

πŸ“œ Tickets

Jira ticket
Github issue

πŸ’‘ Description

Fixed the accessibility label for navigation header title label, for Menu

πŸ“ Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

This is an automatic backport of pull request #23078 done by [Mergify](https://mergify.com).

…ers are not announced (#23078)

FXIOS-10512 #23050 ⁃ [Menu redesign] [Accessibility] - "Tools" and "Save" headers are not announced

(cherry picked from commit 52f77c9)
@mergify mergify bot requested a review from a team as a code owner November 13, 2024 15:08
@mergify mergify bot requested review from ih-codes and removed request for a team November 13, 2024 15:08
@mobiletest-ci-bot
Copy link

Messages
πŸ“– Project coverage: 31.9%
πŸ“– Edited 4 files
πŸ“– Created 0 files

Client.app: Coverage: 30.63

File Coverage
MainMenuDetailsViewController.swift 37.7% ⚠️

Generated by 🚫 Danger Swift against c242aae

@dicarobinho dicarobinho merged commit 00d0299 into release/v133 Nov 13, 2024
12 of 13 checks passed
@dicarobinho dicarobinho deleted the mergify/bp/release/v133/pr-23078 branch November 13, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants