Add FXIOS-10676 Pull refresh refactor feature flag and fix pull refresh issues #23326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 21, 2024 14:35
…paper background to clip top part
Client.app: Coverage: 31.61
Generated by 🚫 Danger Swift against 958b4d4 |
lmarceau
reviewed
Nov 22, 2024
firefox-ios/Client/Frontend/Home/LegacyHomepageViewController.swift
Outdated
Show resolved
Hide resolved
FilippoZazzeroni
changed the title
FilippoZazzeroni
had a problem deploying
to
github-pages
GitHub Actions
Failure
FilippoZazzeroni
changed the title
|
This pull request has conflicts when rebasing. Could you fix it @FilippoZazzeroni? 🙏 |
* Add telemetry for pull refresh * Added correct bugs and data review link to new telemetry --------- Co-authored-by: Filippo <[email protected]>
lmarceau
approved these changes
Nov 25, 2024
|
This pull request has conflicts when rebasing. Could you fix it @FilippoZazzeroni? 🙏 |
FilippoZazzeroni
had a problem deploying
to
github-pages
GitHub Actions
Failure
|
@mergify backport release/v134 |
✅ Backports have been created
|
FilippoZazzeroni
deleted the
zazz/add-feature-flag-for-new-pull-refresh
branch
mergify bot
pushed a commit
that referenced
this pull request
Nov 26, 2024
…sh issues (#23326) * Added pull to refresh refactor feature and restored old UIRefreshControl. * Refactor TabScrollController with feature flag manager * Refactor TabScrollController to inject Pull refresh feature * Fix wallpaper background to clip top part --------- Co-authored-by: Filippo <[email protected]> (cherry picked from commit f1892ff) # Conflicts: # firefox-ios/Client.xcodeproj/project.pbxproj # firefox-ios/Client/Frontend/Home/LegacyHomepageViewController.swift
6 tasks
FilippoZazzeroni
added a commit
that referenced
this pull request
Nov 27, 2024
…sh issues (backport #23326) (#23396) - Add Pull refresh feature flag - Fix pull refresh issues - Restore previous refresh control Co-authored-by: FilippoZazzeroni <[email protected]>
isabelrios
pushed a commit
that referenced
this pull request
Dec 3, 2024
…sh issues (backport #23326) (#23396) - Add Pull refresh feature flag - Fix pull refresh issues - Restore previous refresh control Co-authored-by: FilippoZazzeroni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Add feature flag
Jira ticket
Github issue
Fix pull refresh issues
Jira ticket
Github issue
💡 Description
Add Pull refresh refactor feature.
Fix bug of Homepage wallpaper not covering the status bar in some case, removed pull refresh for tab is home page type.
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)