Refactor FXIOS-10613 [Homepage] Navigation Actions for BVCState #23964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client.app: Coverage: 32.51
Generated by 🚫 Danger Swift against ece3614 |
|
This pull request has conflicts when rebasing. Could you fix it @cyndichin? 🙏 |
cyndichin
force-pushed
the
cc/FXIOS-10613_clean-up-navigation-for-BVCstate
branch
from
a3e1461 to
ece3614
Compare
cyndichin
had a problem deploying
to
github-pages
GitHub Actions
Failure
6 tasks
cyndichin
deleted the
cc/FXIOS-10613_clean-up-navigation-for-BVCstate
branch
MattLichtenstein
pushed a commit
that referenced
this pull request
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
In order to support the ticket of handling navigation actions for top sites / pocket items in the context menu, I did a bit of clean up of our current navigation actions for BVC state.
Instead of duplicating properties between
NavigationBrowserActionandNavigationDestination, this PR consolidates the action's payload to take in thenavigationDestinationproperty instead. Therefore, the state does not need to know how to parse through the separate actions and rather this get handled in thenewStatemethod in BVC instead.📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)