Add FXIOS-10666 Implement iOS "onboarding-opt-out" ping #24101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client.app: Coverage: 32.4
Generated by 🚫 Danger Swift against a6dc557 |
razvanlitianu
changed the title
|
This pull request has conflicts when rebasing. Could you fix it @razvanlitianu? 🙏 |
razvanlitianu
had a problem deploying
to
github-pages
GitHub Actions
Failure
nbhasin2
approved these changes
Jan 20, 2025
razvanlitianu
commented
Jan 21, 2025
| @@ -91,3 +91,26 @@ usage-reporting: | |||
| include_info_sections: false | |||
| ping_schedule: | |||
| - baseline | |||
|
|
|||
| onboarding-opt-out: | |||
There was a problem hiding this comment.
hi @travis79 I was wondering if you think the structure of this ping is correct.
travis79
suggested changes
Jan 21, 2025
firefox-ios/Client/pings.yaml
Outdated
| initial onboarding flow. | ||
| If the global telemetry preference is disabled, this ping | ||
| includes specific settings to ensure it can still be submitted. | ||
| include_client_id: true |
There was a problem hiding this comment.
This should be false, we don't have an ID generated when this ping will be sent so it should not include it.
razvanlitianu
had a problem deploying
to
github-pages
GitHub Actions
Failure
razvanlitianu
deleted the
rlitianu/FXIOS-10666-Implement-iOS-onboarding-opt-out-ping
branch
clarmso
pushed a commit
that referenced
this pull request
Jan 22, 2025
* Add FXIOS-10902 Firefox iOS: Send data deletion request when DAU ping is toggled off * Update data review link * Fix PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
💡 Description
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)