Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix FXIOS-10663 ⁃ [Felt privacy-Unified panel] - Back button from the submenus and from the certificate overlaps the site name #24172

Merged

Conversation

dicarobinho
Copy link
Collaborator

πŸ“œ Tickets

Jira ticket
Github issue

πŸ’‘ Description

Fixed navigationHeader by stop overlapping labels

πŸ“ Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

…ack button from the submenus and from the certificate overlaps the site name
@dicarobinho dicarobinho requested a review from nbhasin2 January 16, 2025 10:43
@dicarobinho dicarobinho marked this pull request as ready for review January 16, 2025 10:43
@dicarobinho dicarobinho requested a review from a team as a code owner January 16, 2025 10:43
@dicarobinho dicarobinho reopened this Jan 16, 2025
@mobiletest-ci-bot
Copy link

Messages
πŸ“– Project coverage: 33.98%
πŸ“– Edited 1 files
πŸ“– Created 0 files

ComponentLibrary: Coverage: 32.84

File Coverage
NavigationHeaderView.swift 50.0% ⚠️

Generated by 🚫 Danger Swift against bbe33eb

@razvanlitianu razvanlitianu self-requested a review January 16, 2025 15:14
@dicarobinho dicarobinho merged commit fa7e28a into main Jan 16, 2025
14 of 15 checks passed
@dicarobinho dicarobinho deleted the afarcasanu/fxios_10663_23324_navigation_header_labels_size branch January 16, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants