Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix FXIOS-10655 ⁃ [Felt privacy-Unified panel] - The name in the Common Name should be blue and underlined on the certificate sheet #24199

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Bugfix FXIOS-10655 ⁃ [Felt privacy-Unified panel] - The name in the Common Name should be blue and underlined on the certificate sheet #24199

merged 2 commits into from
Jan 17, 2025

Conversation

dicarobinho
Copy link
Collaborator

📜 Tickets

Jira ticket
Github issue

💡 Description

Added underline for Issuer Name category, for common name

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@dicarobinho
FXIOS-10655 #23315 ⁃ [Felt privacy-Unified panel] - The name in the C…
5437361 
…ommon Name should be blue and underlined on the certificate sheet
@dicarobinho dicarobinho marked this pull request as ready for review January 17, 2025 07:56
@dicarobinho dicarobinho requested a review from a team as a code owner January 17, 2025 07:56
@mobiletest-ci-bot
Copy link

mobiletest-ci-bot commented Jan 17, 2025 •
edited
Loading

Messages
📖 Project coverage: 34.22%
📖 Edited 2 files
📖 Created 0 files

Client.app: Coverage: 32.4

File Coverage
CertificatesCell.swift 0.0% ⚠️
CertificatesViewController.swift 0.0% ⚠️

Generated by 🚫 Danger Swift against 45792ef

@dicarobinho
Merge branch 'main' into afarcasanu/fxios_10655_23315_common_name_und…
45792ef 
…erlined

# Conflicts:
#	firefox-ios/Client/Frontend/TrackingProtection/CertificatesHelpers/CertificatesCell.swift
razvanlitianu
razvanlitianu approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@razvanlitianu razvanlitianu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@dicarobinho dicarobinho merged commit 9a2cd13 into main Jan 17, 2025
10 of 11 checks passed
@dicarobinho dicarobinho deleted the afarcasanu/fxios_10655_23315_common_name_underlined branch January 17, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razvanlitianu razvanlitianu razvanlitianu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dicarobinho @mobiletest-ci-bot @razvanlitianu