Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix FXIOS-10652 ⁃ Felt privacy-Unified panel] - "Privacy settings" and "View certificate" are not underlined #24201

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Bugfix FXIOS-10652 ⁃ Felt privacy-Unified panel] - "Privacy settings" and "View certificate" are not underlined #24201

merged 1 commit into from
Jan 17, 2025

Conversation

dicarobinho
Copy link
Collaborator

📜 Tickets

Jira ticket
Github issue

💡 Description

Added underline for LinkedButtons

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@dicarobinho
FXIOS-10652 #23309 ⁃ Felt privacy-Unified panel] - "Privacy settings"…
35fbb51 
… and "View certificate" are not underlined
@dicarobinho dicarobinho marked this pull request as ready for review January 17, 2025 10:03
@dicarobinho dicarobinho requested a review from a team as a code owner January 17, 2025 10:03
@dicarobinho
Copy link
Collaborator Author

ImportedPhoto 758801014 961018
ImportedPhoto 758801014 962112

@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 34.22%
📖 Edited 3 files
📖 Created 0 files

Client.app: Coverage: 32.41

File Coverage
TrackingProtectionViewController.swift 12.12% ⚠️
TrackingProtectionDetailsViewController.swift 0.0% ⚠️

ComponentLibrary: Coverage: 32.61

File Coverage
LinkButton.swift 77.14% ✅

Generated by 🚫 Danger Swift against 35fbb51

razvanlitianu
razvanlitianu approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@razvanlitianu razvanlitianu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@dicarobinho dicarobinho merged commit a87d7b1 into main Jan 17, 2025
12 of 14 checks passed
@dicarobinho dicarobinho deleted the afarcasanu/fxios_10652_23309_buttons_not_underlined branch January 17, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razvanlitianu razvanlitianu razvanlitianu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dicarobinho @mobiletest-ci-bot @razvanlitianu