FXIOS-11121 #24248 [Sponsored tiles] Ensure we send to both places for telemetry #24257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyndichin
approved these changes
Jan 21, 2025
lmarceau
force-pushed
the
lm/FXIOS-11121-#24248-send-telemetry-to-both
branch
from
7ce79d0 to
96d772b
Compare
Client.app: Coverage: 32.32
Generated by 🚫 Danger Swift against 6ffa440 |
lmarceau
force-pushed
the
lm/FXIOS-11121-#24248-send-telemetry-to-both
branch
from
a28d455 to
a21fa3c
Compare
cyndichin
approved these changes
Jan 21, 2025
firefox-ios/firefox-ios-tests/Tests/ClientTests/Mocks/MockGleanWrapper.swift
Outdated
Show resolved
Hide resolved
firefox-ios/firefox-ios-tests/Tests/ClientTests/SponsoredTileTelemetryTests.swift
Show resolved
Hide resolved
...ox-ios-tests/Tests/ClientTests/Frontend/Home/TopSites/UnifiedAdsCallbackTelemetryTests.swift
Show resolved
Hide resolved
lmarceau
force-pushed
the
lm/FXIOS-11121-#24248-send-telemetry-to-both
branch
from
9b51cc6 to
6ffa440
Compare
clarmso
pushed a commit
that referenced
this pull request
Jan 22, 2025
…r telemetry (#24257) * Ensure we send to both places for telemetry * Add tests, remove static from SponsoredTileTelemetry todo so * Fix * Remove savedEvent and replace with SavedEvents * Add event check on array * Adjust for latest main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
We should use both endpoints to send telemetry events whenever the Unified Ads api feature flag is turned ON. By maintaining the older Glean pings, we ensure the Looker dashboard continue to work while we migrate to used the Unified Ads api. Data will also be able to be matched between the old and the new APIs, ensuring we remain on par.
In other words, with this PR when the feature flag is ON we show the tiles by using the
UnifiedAdsProvider, but impression and click telemetry are sent with bothSponsoredTileTelemetry(using the Glean pings system) andUnifiedAdsCallbackTelemetry.📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)