Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix FXIOS-11138 [ToS] Landscape mode should not be supported for 'Terms of Service' card to maintain consistency with the other Onboarding Cards #24280

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Bugfix FXIOS-11138 [ToS] Landscape mode should not be supported for 'Terms of Service' card to maintain consistency with the other Onboarding Cards #24280

merged 2 commits into from
Jan 22, 2025

Conversation

dicarobinho
Copy link
Collaborator

📜 Tickets

Jira ticket

💡 Description

Don't allow to display TermsOfServiceViewController in landscape

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@dicarobinho
FXIOS-11138 [Terms of service] Landscape mode should not be supported…
7b00bd2 
… for 'Terms of Service' card to maintain consistency with the other Onboarding Cards
@dicarobinho dicarobinho marked this pull request as ready for review January 22, 2025 12:53
@dicarobinho dicarobinho requested a review from a team as a code owner January 22, 2025 12:53
razvanlitianu
razvanlitianu approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@razvanlitianu razvanlitianu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

nit: Team agreed to not use extension in this way.

@mobiletest-ci-bot
Copy link

mobiletest-ci-bot commented Jan 22, 2025 •
edited
Loading

Messages
📖 Project coverage: 33.14%
📖 Edited 1 files
📖 Created 0 files

Client.app: Coverage: 32.37

File Coverage
TermsOfServiceViewController.swift 81.42% ✅

Generated by 🚫 Danger Swift against 370d03d

@dicarobinho dicarobinho merged commit dee1f07 into main Jan 22, 2025
10 checks passed
@dicarobinho dicarobinho deleted the afarcasanu/fxios_11138_landscape_mode_should_not_be_supported branch January 22, 2025 13:42
clarmso pushed a commit that referenced this pull request Jan 22, 2025
@dicarobinho @clarmso
Bugfix FXIOS-11138 [ToS] Landscape mode should not be supported for '…
05a4018 
…Terms of Service' card to maintain consistency with the other Onboarding Cards (#24280)

* FXIOS-11138 [Terms of service] Landscape mode should not be supported for 'Terms of Service' card to maintain consistency with the other Onboarding Cards

* Moved override methods inside the main class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razvanlitianu razvanlitianu razvanlitianu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dicarobinho @mobiletest-ci-bot @razvanlitianu