Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor [v136] Auto update SPM with latest rust-component 136.0.20250122050310 #24283

Merged

Conversation

github-actions[bot]
Copy link
Contributor

Automated changes by create-pull-request GitHub action

@github-actions github-actions bot requested a review from a team as a code owner January 22, 2025 15:06
@github-actions github-actions bot requested a review from mdotb-moz January 22, 2025 15:06
@lmarceau
Copy link
Contributor

lmarceau commented Jan 22, 2025

Bunch of RustLogins failure happened on this version update

@lmarceau
Copy link
Contributor

I guess this is the same as #24265, so tagging @issammani. We should merge the most recent of this PR, so I'll close the older one

@lmarceau lmarceau requested review from issammani and removed request for mdotb-moz January 22, 2025 15:39
@issammani
Copy link
Collaborator

I guess this is the same as #24265, so tagging @issammani. We should merge the most recent of this PR, so I'll close the older one

Yes. The fix is in #24108. Some tests related to my changes are still failing fixing those and merging 😄

@issammani issammani added the Do Not Merge ⛔️ This issue is a work in progress and is not ready to land label Jan 22, 2025
@issammani issammani force-pushed the update-spm-new-rust-component-tag-136.0.20250122050310 branch from bb007a0 to 2b8b691 Compare January 23, 2025 13:24
@issammani
Copy link
Collaborator

Waiting for BR to be green now that #24108 fixed the logins change in AS.

@issammani issammani removed the Do Not Merge ⛔️ This issue is a work in progress and is not ready to land label Jan 23, 2025
@mobiletest-ci-bot
Copy link

Messages
📖 Edited 4 files
📖 Created 0 files

Generated by 🚫 Danger Swift against 2b8b691

@issammani issammani merged commit dc7a2cb into main Jan 23, 2025
13 checks passed
@issammani issammani deleted the update-spm-new-rust-component-tag-136.0.20250122050310 branch January 23, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants