delegate review actions to cinder #23004
Open
+662
−267
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: mozilla/addons#1982
Description
Refactors code in the ContentAction classes, and ReviewHelper to allow activity logging to be consistently generated; migrates Disable Add-on action from the reviewer tools to ContentAction classes.
Context
The primary motivation for this work (what this blocks) is 2nd level approvals for reviewer tools originated decisions - and only certain types of decision (add-on disables and addon version rejections) will be held - so not all actions need to be rewritten at this point. This PR starts with disable_addon as it's a) already implemented for cinder originated decisions and b) relatively straightforward.
I had to tinker with some existing migrations to fix breakage caused by migrations executing in a different order now (though they were only a problem in CI or with a fresh database anyway)
Testing
The main change is how Disable Addon is executed from the reviewer tools:
Repeat with an add-on that would be considered high profile - e.g. a Recommended or Notable add-on.
Checklist
#ISSUENUM
at the top of your PR to an existing open issue in the mozilla/addons repository.