Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent JS errors on IE8 #15871

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Prevent JS errors on IE8 #15871

merged 2 commits into from
Jan 16, 2025

Conversation

alexgibson
Copy link
Member

@alexgibson alexgibson commented Jan 15, 2025 •
edited
Loading

One-line summary

Prevents 2 JS errors on IE8:

  • Loading Google Analytics (which seems unsupported there anyways, it throws an error even when it loads).
  • Loading the newsletter JS in the footer on redesigned pages.

Significant changes and points to review

  • Note that we still load GA for IE9, even though it doesn't get regular page specific JS.

Issue / Bugzilla link

#15867

Testing

There should be no JS errors when loading the home page on IE8: https://www-demo1.allizom.org/en-US/

@alexgibson alexgibson changed the title Ie js error Prevent JS errors on IE8 Jan 15, 2025
@alexgibson alexgibson added P3 Third level priority - Nice to have Needs Review Awaiting code review Review: XS Code review time: up to 30min Frontend HTML, CSS, JS... client side stuff labels Jan 15, 2025
@alexgibson alexgibson marked this pull request as ready for review January 15, 2025 10:14
@alexgibson alexgibson requested a review from a team as a code owner January 15, 2025 10:14
@janbrasna janbrasna mentioned this pull request Jan 15, 2025
Open
stephaniehobson
stephaniehobson approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@stephaniehobson stephaniehobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R+

@stephaniehobson stephaniehobson merged commit 95a5abb into mozilla:main Jan 16, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephaniehobson stephaniehobson stephaniehobson approved these changes

Assignees
No one assigned
Labels
Frontend HTML, CSS, JS... client side stuff Needs Review Awaiting code review P3 Third level priority - Nice to have Review: XS Code review time: up to 30min
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexgibson @stephaniehobson