-
Notifications
You must be signed in to change notification settings - Fork 28
issue #242 - added rule for Civic Cookie Control CMP #299
base: main
Are you sure you want to change the base?
Conversation
As I was also trying to figure out this CMP, I would like to share my findings with you. From what I've learned, websites that use the cookie consent manager provided by CIVIC use it in two different ways:
Given this and the fact that you are already working on it, I would suggest something like this: {
"id": "civiccookiecontrolbar",
"domains": [],
"click": {
"presence": "#ccc-notify",
"optOut": "#ccc-notify-reject",
"optIn": "#ccc-notify-accept"
}
},
{
"id": "civiccookiecontrolsidepane",
"domains": [],
"click": {
"presence": "#cc-panel",
"optOut": "#ccc-reject-settings",
"optIn": "#ccc-recommended-settings"
}
} Unfortunately, while testing the correctness on my side on various websites, I came across one site (metoffice.gov.uk) that does not fully respect the user's preferences, and clicking the reject button in that side panel still allows for the so-called legitimate interest. Therefore, I have some concerns that, in some cases, automatically closing cookie banners may be more harmful than helpful. More websites would be needed to test how it works on them. I've found about 5 so far. Additionally, the addition of this new global policy will make several already existing per-site rules redundant, namely:
Since you are already working on it, please consider removing them as part of this pull request. |
Co-authored-by: Paul Zühlcke <[email protected]>
Co-authored-by: Paul Zühlcke <[email protected]>
Co-authored-by: Paul Zühlcke <[email protected]>
* Add rule for lieferando.de * Add just-eat.ch to lieferando rule. --------- Co-authored-by: Paul Zühlcke <[email protected]>
* Add rule for mindfactory.de
Co-authored-by: abhishekmadan30 <[email protected]>
@Greg-21: Thanks for the feedback! Great, I obviously did something wrong when updating the PR with the latest changes from upstream and with your feedback, now a lot of irrelevant commits are part of the PR. 🙄 I'll have to fix it somehow. Anyway, I also think it wouldn't hurt to do a little more testing here. I don't have time the whole next week due to other commitments. I have changed this PR to a draft for now. But feel free to take over if you want. |
It's not so bad. Just rebase this branch onto the current If you need a list of about 10 different random websites using this CMP that I managed to prepare for testing purposes, let me know, and I will share it with you somehow. |
issue #242