Skip to content
This repository has been archived by the owner on Jan 7, 2025. It is now read-only.

issue #242 - added rule for Civic Cookie Control CMP #299

Draft
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

cadeyrn
Copy link
Contributor

@cadeyrn cadeyrn commented Nov 25, 2023

issue #242

@cadeyrn cadeyrn requested a review from a team as a code owner November 25, 2023 11:41
@Greg-21
Copy link
Contributor

Greg-21 commented Nov 25, 2023

As I was also trying to figure out this CMP, I would like to share my findings with you. From what I've learned, websites that use the cookie consent manager provided by CIVIC use it in two different ways:

  • most of them, when visited, slide out a bar from the bottom of the screen that usually contains three buttons: accept all, reject all (this one is not there in some cases), and preferences. Clicking the preference button causes a side pane to appear and slide out from the left, where users can specify their cookie preferences in detail. (This is what you may or may not need to add support for in your pull request)
  • the rest slide out the side pane with advanced preferences from the left when you visit them and throw the user in at the deep end. (This is what you've covered in your pull request so far)

Given this and the fact that you are already working on it, I would suggest something like this:

{
  "id": "civiccookiecontrolbar",
  "domains": [],
  "click": {
    "presence": "#ccc-notify",
    "optOut": "#ccc-notify-reject",
    "optIn": "#ccc-notify-accept"
  }
},
{
  "id": "civiccookiecontrolsidepane",
  "domains": [],
  "click": {
    "presence": "#cc-panel",
    "optOut": "#ccc-reject-settings",
    "optIn": "#ccc-recommended-settings"
  }
}

Unfortunately, while testing the correctness on my side on various websites, I came across one site (metoffice.gov.uk) that does not fully respect the user's preferences, and clicking the reject button in that side panel still allows for the so-called legitimate interest. Therefore, I have some concerns that, in some cases, automatically closing cookie banners may be more harmful than helpful. More websites would be needed to test how it works on them. I've found about 5 so far.

Additionally, the addition of this new global policy will make several already existing per-site rules redundant, namely:

  • metoffice.gov.uk
  • ox.ac.uk
  • tapad.com

Since you are already working on it, please consider removing them as part of this pull request.

alesar1 and others added 24 commits December 3, 2023 23:01
* Add rule for lieferando.de
* Add just-eat.ch to lieferando rule.

---------

Co-authored-by: Paul Zühlcke <[email protected]>
* Add rule for mindfactory.de
@cadeyrn cadeyrn marked this pull request as draft December 3, 2023 22:12
@cadeyrn
Copy link
Contributor Author

cadeyrn commented Dec 3, 2023

@Greg-21: Thanks for the feedback!

Great, I obviously did something wrong when updating the PR with the latest changes from upstream and with your feedback, now a lot of irrelevant commits are part of the PR. 🙄 I'll have to fix it somehow.

Anyway, I also think it wouldn't hurt to do a little more testing here. I don't have time the whole next week due to other commitments. I have changed this PR to a draft for now. But feel free to take over if you want.

@Greg-21
Copy link
Contributor

Greg-21 commented Dec 6, 2023

It's not so bad. Just rebase this branch onto the current main and you're all set.

If you need a list of about 10 different random websites using this CMP that I managed to prepare for testing purposes, let me know, and I will share it with you somehow.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants