Priority headers should be set by the application #1725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valenting
requested review from
KershawChang,
martinthomson and
larseggert
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1725 +/- ##
==========================================
- Coverage 92.98% 92.96% -0.03%
==========================================
Files 120 120
Lines 37399 37396 -3
==========================================
- Hits 34775 34764 -11
- Misses 2624 2632 +8 ☔ View full report in Codecov by Sentry. |
larseggert
reviewed
Mar 8, 2024
|
LGTM, but I'd like to see another review, since the related Fx parts are new to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of setting the priority headers in neqo, the headers should be provided by the application.
See related https://phabricator.services.mozilla.com/D201265