Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add concurrency to top-level workflows #1737

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

larseggert
Copy link
Collaborator

So that a failure stops all CI for a PR.

So that a failure stops all CI for a PR.
Copy link

github-actions bot commented Mar 12, 2024

QUIC Interop Runner

Saving logs to logs.
Run took 0:03:32.939983
Server: neqo-latest. Client: neqo-latest. Running test case: handshake
Server: quic-go. Client: neqo-latest. Running test case: handshake
Server: ngtcp2. Client: neqo-latest. Running test case: handshake
Server: neqo. Client: neqo-latest. Running test case: handshake
Server: msquic. Client: neqo-latest. Running test case: handshake
Server: neqo-latest. Client: quic-go. Running test case: handshake
Server: neqo-latest. Client: ngtcp2. Running test case: handshake
Server: neqo-latest. Client: neqo. Running test case: handshake
Server: neqo-latest. Client: msquic. Running test case: handshake
+-------------+-------------+---------+--------+------+--------+
|             | neqo-latest | quic-go | ngtcp2 | neqo | msquic |
+-------------+-------------+---------+--------+------+--------+
| neqo-latest |     ✓(H)    |   ✓(H)  |  ✓(H)  | ✓(H) |  ✓(H)  |
|             |     ?()     |   ?()   |  ?()   | ?()  |  ?()   |
|             |     ✕()     |   ✕()   |  ✕()   | ✕()  |  ✕()   |
+-------------+-------------+---------+--------+------+--------+
|   quic-go   |     ✓(H)    |         |        |      |        |
|             |     ?()     |         |        |      |        |
|             |     ✕()     |         |        |      |        |
+-------------+-------------+---------+--------+------+--------+
|    ngtcp2   |     ✓(H)    |         |        |      |        |
|             |     ?()     |         |        |      |        |
|             |     ✕()     |         |        |      |        |
+-------------+-------------+---------+--------+------+--------+
|     neqo    |     ✓(H)    |         |        |      |        |
|             |     ?()     |         |        |      |        |
|             |     ✕()     |         |        |      |        |
+-------------+-------------+---------+--------+------+--------+
|    msquic   |     ✓(H)    |         |        |      |        |
|             |     ?()     |         |        |      |        |
|             |     ✕()     |         |        |      |        |
+-------------+-------------+---------+--------+------+--------+

⬇️ Download logs

@larseggert larseggert enabled auto-merge March 12, 2024 15:20
Copy link

Benchmark results

  • coalesce_acked_from_zero 1+1 entries
    time: [255.29 ns 255.88 ns 256.52 ns]
    change: [+1.4303% +1.8578% +2.2484%] (p = 0.00 < 0.05)
    💔 Performance has regressed.

  • coalesce_acked_from_zero 3+1 entries
    time: [291.99 ns 292.64 ns 293.40 ns]
    change: [+1.5869% +1.9582% +2.3270%] (p = 0.00 < 0.05)
    💔 Performance has regressed.

  • coalesce_acked_from_zero 10+1 entries
    time: [291.38 ns 295.59 ns 303.67 ns]
    change: [+1.2939% +2.7757% +5.9409%] (p = 0.00 < 0.05)
    💔 Performance has regressed.

  • coalesce_acked_from_zero 1000+1 entries
    time: [267.41 ns 267.58 ns 267.79 ns]
    change: [+2.8109% +3.5634% +4.3561%] (p = 0.00 < 0.05)
    💔 Performance has regressed.

  • RxStreamOrderer::inbound_frame()
    time: [125.66 ms 125.82 ms 126.07 ms]
    change: [+2.9658% +3.1081% +3.3089%] (p = 0.00 < 0.05)
    💔 Performance has regressed.

  • Run multiple transfers with varying seeds
    time: [187.41 ms 188.08 ms 188.73 ms]
    change: [-7.1184% -6.6846% -6.2282%] (p = 0.00 < 0.05)
    💚 Performance has improved.

  • Run multiple transfers with the same seed
    time: [189.57 ms 189.88 ms 190.20 ms]
    change: [-5.2690% -5.0327% -4.7975%] (p = 0.00 < 0.05)
    💚 Performance has improved.

⬇️ Download logs

@larseggert larseggert added this pull request to the merge queue Mar 12, 2024
Merged via the queue into mozilla:main with commit 66d8365 Mar 12, 2024
13 checks passed
@larseggert larseggert deleted the ci-concurrency branch March 12, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants