fix: Log rttvar in qlog
#2005
Merged
fix: Log rttvar in qlog
#2005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2005 +/- ##
=======================================
Coverage 94.99% 94.99%
=======================================
Files 112 112
Lines 36371 36372 +1
=======================================
+ Hits 34552 34553 +1
Misses 1819 1819 ☔ View full report in Codecov by Sentry. |
Benchmark resultsPerformance differences relative to 608c0a7. coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [193.30 ns 193.73 ns 194.17 ns]
change: [-0.7435% -0.2437% +0.1736%] (p = 0.33 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [237.05 ns 237.73 ns 238.43 ns]
change: [-0.9925% -0.2951% +0.3160%] (p = 0.41 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [236.30 ns 237.04 ns 237.92 ns]
change: [-0.5894% -0.2239% +0.1316%] (p = 0.25 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [217.05 ns 217.22 ns 217.40 ns]
change: [-0.3995% +0.2847% +1.0225%] (p = 0.46 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [119.91 ms 119.99 ms 120.08 ms]
change: [-0.5646% -0.3439% -0.1781%] (p = 0.00 < 0.05)
transfer/Run multiple transfers with varying seeds: No change in performance detected. time: [55.995 ms 59.163 ms 62.307 ms]
thrpt: [64.198 MiB/s 67.610 MiB/s 71.435 MiB/s]
change:
time: [-10.578% -3.4847% +3.8872%] (p = 0.36 > 0.05)
thrpt: [-3.7418% +3.6105% +11.830%]
transfer/Run multiple transfers with the same seed: No change in performance detected. time: [68.304 ms 73.395 ms 78.390 ms]
thrpt: [51.027 MiB/s 54.500 MiB/s 58.562 MiB/s]
change:
time: [-5.8779% +5.0685% +17.802%] (p = 0.39 > 0.05)
thrpt: [-15.112% -4.8240% +6.2450%]
1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected. time: [274.45 ms 288.46 ms 299.04 ms]
thrpt: [334.41 MiB/s 346.67 MiB/s 364.37 MiB/s]
change:
time: [-7.1290% -2.3989% +1.9128%] (p = 0.39 > 0.05)
thrpt: [-1.8769% +2.4579% +7.6762%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected. time: [411.80 ms 415.18 ms 418.61 ms]
thrpt: [23.888 Kelem/s 24.086 Kelem/s 24.284 Kelem/s]
change:
time: [-1.2585% -0.1799% +0.9976%] (p = 0.75 > 0.05)
thrpt: [-0.9877% +0.1803% +1.2745%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected. time: [67.797 ms 68.052 ms 68.356 ms]
thrpt: [14.629 elem/s 14.695 elem/s 14.750 elem/s]
change:
time: [-1.3208% -0.6245% +0.1168%] (p = 0.09 > 0.05)
thrpt: [-0.1167% +0.6284% +1.3384%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
mxinden
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Otherwise looks good to me.
; all following rtt fields are expressed in ms
https://quicwg.org/qlog/draft-ietf-quic-qlog-quic-events.html#name-metrics_updated
Slightly related note, why is qlog not using SI units?
Co-authored-by: Max Inden <[email protected]> Signed-off-by: Lars Eggert <[email protected]>
This reverts commit cf986bb. `as_millis_f32` is nightly experimental.
mxinden
approved these changes
Jul 24, 2024
|
Are there other qlog probes we are missing? |
|
I assume most missing ones are tracked in #528 @larseggert. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.