deps: enable std feature of url crate #2219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`url` `v0.5.3` and `idna` `v1.0.3` added no-std support: servo/rust-url#831 Since Neqo sets `default-features = false`, the above would break Neqo. Related: servo/rust-url#831
larseggert
approved these changes
Nov 5, 2024
|
|
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2219 +/- ##
=======================================
Coverage 95.39% 95.39%
=======================================
Files 112 112
Lines 36447 36447
=======================================
Hits 34767 34767
Misses 1680 1680 ☔ View full report in Codecov by Sentry. |
Merged
mxinden
added a commit
to mxinden/neqo
that referenced
this pull request
Nov 19, 2024
mozilla-central depends on `url` `v2.5.1`: https://searchfox.org/mozilla-central/rev/6050bf4eca89956c9d91bfd89fa59294ae32a689/Cargo.lock#6715-6725 The latest version of `url` is `v2.5.3`, which cargo automatically updates to, given that `Cargo.lock` is not checked in. `url` v0.2.5.3` introduced the `std` feature which breaks CI. mozilla#2219 enabled the feature, unbreaking CI, but breaking mozilla-central, given that mozilla-central still uses `url` `v2.5.1` which does not have the the `std` feature. This commit pins `url` to `v2.5.1` instead and removes the `std` feature.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 19, 2024
mozilla-central depends on `url` `v2.5.1`: https://searchfox.org/mozilla-central/rev/6050bf4eca89956c9d91bfd89fa59294ae32a689/Cargo.lock#6715-6725 The latest version of `url` is `v2.5.3`, which cargo automatically updates to, given that `Cargo.lock` is not checked in. `url` v0.2.5.3` introduced the `std` feature which breaks CI. #2219 enabled the feature, unbreaking CI, but breaking mozilla-central, given that mozilla-central still uses `url` `v2.5.1` which does not have the the `std` feature. This commit pins `url` to `v2.5.1` instead and removes the `std` feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
urlv0.5.3andidnav1.0.3added no-std support: servo/rust-url#831Since Neqo sets
default-features = false, the above would break Neqo.Related: servo/rust-url#831
Sample CI failure: https://github.com/mozilla/neqo/actions/runs/11683021003/job/32531372545