ci: Further fixes after merge of #2413

[larseggert]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.28%. Comparing base (12dc9e9) to head (c15bbc9).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2415   +/-   ##
=======================================
  Coverage   95.28%   95.28%           
=======================================
  Files         114      114           
  Lines       37111    37111           
  Branches    37111    37111           
=======================================
+ Hits        35362    35363    +1     
+ Misses       1743     1742    -1     
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Benchmark results

Performance differences relative to ed0a053.

decode 4096 bytes, mask ff: Change within noise threshold.

       time:   [11.787 µs 11.819 µs 11.858 µs]
       change: [-1.2300% -0.6013% -0.0637%] (p = 0.05 < 0.05)
Found 15 outliers among 100 measurements (15.00%)

1 (1.00%) low severe

4 (4.00%) low mild

3 (3.00%) high mild

7 (7.00%) high severe

decode 1048576 bytes, mask ff: No change in performance detected.

       time:   [2.9135 ms 2.9263 ms 2.9398 ms]
       change: [-0.0516% +0.5272% +1.1107%] (p = 0.08 > 0.05)
Found 16 outliers among 100 measurements (16.00%)

16 (16.00%) high severe

decode 4096 bytes, mask 7f: No change in performance detected.

       time:   [19.681 µs 19.725 µs 19.777 µs]
       change: [-0.9736% -0.1349% +0.4796%] (p = 0.77 > 0.05)
Found 19 outliers among 100 measurements (19.00%)

1 (1.00%) low severe

3 (3.00%) low mild

2 (2.00%) high mild

13 (13.00%) high severe

decode 1048576 bytes, mask 7f: No change in performance detected.

       time:   [4.7202 ms 4.7396 ms 4.7657 ms]
       change: [-0.1434% +0.3438% +0.9651%] (p = 0.23 > 0.05)
Found 16 outliers among 100 measurements (16.00%)

16 (16.00%) high severe

decode 4096 bytes, mask 3f: No change in performance detected.

       time:   [6.2098 µs 6.2369 µs 6.2704 µs]
       change: [-0.7879% -0.1503% +0.5817%] (p = 0.67 > 0.05)
Found 19 outliers among 100 measurements (19.00%)

9 (9.00%) low mild

3 (3.00%) high mild

7 (7.00%) high severe

decode 1048576 bytes, mask 3f: No change in performance detected.

       time:   [2.1123 ms 2.1191 ms 2.1261 ms]
       change: [-0.6545% -0.1318% +0.3892%] (p = 0.63 > 0.05)
Found 9 outliers among 100 measurements (9.00%)

1 (1.00%) high mild

8 (8.00%) high severe

coalesce_acked_from_zero 1+1 entries: No change in performance detected.

       time:   [93.324 ns 93.650 ns 93.982 ns]
       change: [-0.4719% -0.0032% +0.4570%] (p = 0.99 > 0.05)
Found 13 outliers among 100 measurements (13.00%)

10 (10.00%) high mild

3 (3.00%) high severe

coalesce_acked_from_zero 3+1 entries: No change in performance detected.

       time:   [110.68 ns 111.05 ns 111.45 ns]
       change: [-0.3372% -0.0111% +0.3420%] (p = 0.96 > 0.05)
Found 16 outliers among 100 measurements (16.00%)

3 (3.00%) low mild

2 (2.00%) high mild

11 (11.00%) high severe

coalesce_acked_from_zero 10+1 entries: Change within noise threshold.

       time:   [110.08 ns 110.32 ns 110.69 ns]
       change: [-1.7056% -0.8299% -0.1402%] (p = 0.03 < 0.05)
Found 7 outliers among 100 measurements (7.00%)

2 (2.00%) low severe

1 (1.00%) low mild

1 (1.00%) high mild

3 (3.00%) high severe

coalesce_acked_from_zero 1000+1 entries: No change in performance detected.

       time:   [92.558 ns 92.679 ns 92.814 ns]
       change: [-1.3728% -0.4738% +0.4381%] (p = 0.34 > 0.05)
Found 11 outliers among 100 measurements (11.00%)

6 (6.00%) high mild

5 (5.00%) high severe

RxStreamOrderer::inbound_frame(): 💚 Performance has improved.

       time:   [111.62 ms 111.75 ms 111.97 ms]
       change: [-1.4897% -1.3578% -1.1609%] (p = 0.00 < 0.05)
Found 19 outliers among 100 measurements (19.00%)

9 (9.00%) low mild

9 (9.00%) high mild

1 (1.00%) high severe

SentPackets::take_ranges: No change in performance detected.

       time:   [5.1510 µs 5.2282 µs 5.3008 µs]
       change: [-3.7955% -1.2124% +1.4835%] (p = 0.39 > 0.05)
Found 5 outliers among 100 measurements (5.00%)

4 (4.00%) high mild

1 (1.00%) high severe

transfer/pacing-false/varying-seeds: 💚 Performance has improved.

       time:   [38.069 ms 38.143 ms 38.226 ms]
       change: [-5.5949% -5.3117% -5.0153%] (p = 0.00 < 0.05)
Found 1 outliers among 100 measurements (1.00%)

1 (1.00%) high severe

transfer/pacing-true/varying-seeds: 💚 Performance has improved.

       time:   [38.293 ms 38.369 ms 38.447 ms]
       change: [-5.6481% -5.3706% -5.0908%] (p = 0.00 < 0.05)
Found 1 outliers among 100 measurements (1.00%)

1 (1.00%) high mild

transfer/pacing-false/same-seed: 💚 Performance has improved.

       time:   [38.196 ms 38.279 ms 38.375 ms]
       change: [-5.4731% -5.1815% -4.8538%] (p = 0.00 < 0.05)
Found 2 outliers among 100 measurements (2.00%)

1 (1.00%) high mild

1 (1.00%) high severe

transfer/pacing-true/same-seed: 💚 Performance has improved.

       time:   [38.658 ms 38.726 ms 38.800 ms]
       change: [-4.0888% -3.8116% -3.5468%] (p = 0.00 < 0.05)
Found 2 outliers among 100 measurements (2.00%)

1 (1.00%) low mild

1 (1.00%) high severe

1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: Change within noise threshold.

       time:   [832.98 ms 843.10 ms 853.31 ms]
       thrpt:  [117.19 MiB/s 118.61 MiB/s 120.05 MiB/s]
change:
       time:   [-3.9403% -2.3199% -0.6087%] (p = 0.01 < 0.05)
       thrpt:  [+0.6124% +2.3750% +4.1020%]

1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected.

       time:   [316.13 ms 319.59 ms 323.10 ms]
       thrpt:  [30.951 Kelem/s 31.290 Kelem/s 31.632 Kelem/s]
change:
       time:   [-1.3999% +0.1539% +1.7692%] (p = 0.85 > 0.05)
       thrpt:  [-1.7384% -0.1537% +1.4198%]

1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected.

       time:   [25.469 ms 25.641 ms 25.816 ms]
       thrpt:  [38.735  elem/s 38.999  elem/s 39.263  elem/s]
change:
       time:   [-1.2068% -0.3037% +0.6678%] (p = 0.54 > 0.05)
       thrpt:  [-0.6634% +0.3047% +1.2215%]
Found 1 outliers among 100 measurements (1.00%)

1 (1.00%) high mild

1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: 💚 Performance has improved.

       time:   [1.8197 s 1.8461 s 1.8727 s]
       thrpt:  [53.399 MiB/s 54.168 MiB/s 54.955 MiB/s]
change:
       time:   [-4.9241% -3.1696% -1.5844%] (p = 0.00 < 0.05)
       thrpt:  [+1.6099% +3.2734% +5.1791%]

Client/server transfer results

Transfer of 33554432 bytes over loopback.

Client	Server	CC	Pacing	MTU	Mean [ms]	Min [ms]	Max [ms]
gquiche	gquiche			1504	548.1 ± 78.0	502.7	740.6
neqo	gquiche	reno	on	1504	753.9 ± 10.8	737.9	770.5
neqo	gquiche	reno		1504	754.4 ± 16.9	736.0	794.9
neqo	gquiche	cubic	on	1504	749.9 ± 14.6	724.2	775.3
neqo	gquiche	cubic		1504	801.6 ± 90.8	744.9	982.7
msquic	msquic			1504	103.2 ± 11.4	90.2	123.3
neqo	msquic	reno	on	1504	206.2 ± 9.0	196.7	221.8
neqo	msquic	reno		1504	206.1 ± 10.7	193.8	227.5
neqo	msquic	cubic	on	1504	256.4 ± 77.8	207.9	460.3
neqo	msquic	cubic		1504	208.1 ± 10.0	197.0	222.7
gquiche	neqo	reno	on	1504	666.8 ± 77.9	538.7	778.8
gquiche	neqo	reno		1504	641.1 ± 84.5	523.9	763.2
gquiche	neqo	cubic	on	1504	665.2 ± 90.4	545.0	777.4
gquiche	neqo	cubic		1504	636.0 ± 83.5	511.5	765.6
msquic	neqo	reno	on	1504	444.1 ± 7.4	434.4	451.7
msquic	neqo	reno		1504	474.6 ± 61.7	441.5	646.2
msquic	neqo	cubic	on	1504	450.3 ± 12.4	436.1	470.4
msquic	neqo	cubic		1504	433.7 ± 11.2	417.8	451.4
neqo	neqo	reno	on	1504	420.6 ± 10.7	408.1	443.3
neqo	neqo	reno		1504	416.2 ± 10.0	399.2	432.6
neqo	neqo	cubic	on	1504	472.5 ± 94.1	419.6	683.9
neqo	neqo	cubic		1504	434.8 ± 16.5	414.1	472.1

⬇️ Download logs