fix: only enable quinn-udp fast-apple-datapath on arm #2427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxinden
force-pushed
the
fast-apple-datapath-arm
branch
from
4f94edf to
3b8f248
Compare
Failed Interop TestsNone ❓ All resultsSucceeded Interop TestsNone ❓ Unsupported Interop TestsNone ❓ |
|
This is odd, because IIRC these syscalls predate Catalina by years. |
|
Thanks @larseggert for the info. All suspicions for now. I just know it is related to Neqo Might as well be a syscall from the (Thus far I have no other way to reproduce than Mozilla's CI, a single run take ~6h, and logs have not been helpful.) I will continue to debug this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only enable
fast-apple-datapathon aarch64.Old MacOS versions (e.g. 10.15) don't fully support
sendmsg_xandrecvmsg_x, both enabled byfast-apple-datapath. Instead of feature gating by OS version, simply do so by CPU arch, leveraging the fact that newer MacOS devices use ARM.Draft for now. Debugging mozilla-central failure on MacOS 10.15.