Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump lukemathwalker/cargo-chef from ca7d16d to 66b16e2 in /qns #2432

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 10, 2025

Bumps lukemathwalker/cargo-chef from ca7d16d to 66b16e2.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps lukemathwalker/cargo-chef from `ca7d16d` to `66b16e2`.

---
updated-dependencies:
- dependency-name: lukemathwalker/cargo-chef
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from KershawChang as a code owner February 10, 2025 08:34
@dependabot dependabot bot added dependencies Pull requests that update a dependency file docker Pull requests that update Docker code labels Feb 10, 2025
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.28%. Comparing base (b6e4cfc) to head (70a16fd).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2432   +/-   ##
=======================================
  Coverage   95.28%   95.28%           
=======================================
  Files         114      114           
  Lines       37111    37111           
  Branches    37111    37111           
=======================================
+ Hits        35362    35363    +1     
+ Misses       1743     1742    -1     
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@larseggert larseggert added this pull request to the merge queue Feb 10, 2025
Copy link

Failed Interop Tests

QUIC Interop Runner, client vs. server, differences relative to b6e4cfc.

neqo-latest as client

neqo-latest as server

All results

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Unsupported Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Merged via the queue into main with commit ebe82e3 Feb 10, 2025
70 of 72 checks passed
@larseggert larseggert deleted the dependabot/docker/qns/lukemathwalker/cargo-chef-66b16e2261871e522c3c8b2bc2da4222843e03b3581f4f2a98ac8fc59fa3d3ae branch February 10, 2025 09:31
Copy link

Benchmark results

Performance differences relative to b6e4cfc.

decode 4096 bytes, mask ff: No change in performance detected.
       time:   [10.866 µs 10.903 µs 10.947 µs]
       change: [-0.2626% +0.3062% +0.8865%] (p = 0.34 > 0.05)

Found 18 outliers among 100 measurements (18.00%)
2 (2.00%) low severe
6 (6.00%) low mild
1 (1.00%) high mild
9 (9.00%) high severe

decode 1048576 bytes, mask ff: No change in performance detected.
       time:   [3.1302 ms 3.1406 ms 3.1526 ms]
       change: [-0.2763% +0.1884% +0.6416%] (p = 0.44 > 0.05)

Found 11 outliers among 100 measurements (11.00%)
11 (11.00%) high severe

decode 4096 bytes, mask 7f: No change in performance detected.
       time:   [17.628 µs 17.673 µs 17.725 µs]
       change: [-1.1229% -0.4308% +0.1576%] (p = 0.21 > 0.05)

Found 22 outliers among 100 measurements (22.00%)
2 (2.00%) low severe
5 (5.00%) low mild
1 (1.00%) high mild
14 (14.00%) high severe

decode 1048576 bytes, mask 7f: No change in performance detected.
       time:   [5.4029 ms 5.4159 ms 5.4307 ms]
       change: [-0.4049% -0.0586% +0.3038%] (p = 0.76 > 0.05)

Found 14 outliers among 100 measurements (14.00%)
14 (14.00%) high severe

decode 4096 bytes, mask 3f: No change in performance detected.
       time:   [6.6622 µs 6.6915 µs 6.7240 µs]
       change: [-0.4391% +0.5264% +1.7425%] (p = 0.34 > 0.05)

Found 9 outliers among 100 measurements (9.00%)
4 (4.00%) low mild
3 (3.00%) high mild
2 (2.00%) high severe

decode 1048576 bytes, mask 3f: Change within noise threshold.
       time:   [1.7581 ms 1.7583 ms 1.7585 ms]
       change: [-0.0335% -0.0202% -0.0059%] (p = 0.01 < 0.05)

Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mild

coalesce_acked_from_zero 1+1 entries: No change in performance detected.
       time:   [91.035 ns 91.376 ns 91.736 ns]
       change: [-0.6924% -0.1360% +0.3846%] (p = 0.62 > 0.05)

Found 10 outliers among 100 measurements (10.00%)
7 (7.00%) high mild
3 (3.00%) high severe

coalesce_acked_from_zero 3+1 entries: No change in performance detected.
       time:   [109.36 ns 109.73 ns 110.11 ns]
       change: [-0.0183% +0.2963% +0.6465%] (p = 0.08 > 0.05)

Found 16 outliers among 100 measurements (16.00%)
2 (2.00%) low mild
3 (3.00%) high mild
11 (11.00%) high severe

coalesce_acked_from_zero 10+1 entries: No change in performance detected.
       time:   [109.18 ns 109.70 ns 110.29 ns]
       change: [-0.9399% -0.1340% +0.6046%] (p = 0.75 > 0.05)

Found 13 outliers among 100 measurements (13.00%)
2 (2.00%) low mild
3 (3.00%) high mild
8 (8.00%) high severe

coalesce_acked_from_zero 1000+1 entries: No change in performance detected.
       time:   [93.452 ns 93.599 ns 93.768 ns]
       change: [-0.8289% +0.1038% +0.9805%] (p = 0.83 > 0.05)

Found 10 outliers among 100 measurements (10.00%)
5 (5.00%) high mild
5 (5.00%) high severe

RxStreamOrderer::inbound_frame(): Change within noise threshold.
       time:   [111.43 ms 111.48 ms 111.53 ms]
       change: [+0.0616% +0.1228% +0.1906%] (p = 0.00 < 0.05)

Found 15 outliers among 100 measurements (15.00%)
8 (8.00%) low mild
7 (7.00%) high mild

SentPackets::take_ranges: No change in performance detected.
       time:   [5.2727 µs 5.4328 µs 5.6017 µs]
       change: [-16.688% -4.4624% +4.4324%] (p = 0.64 > 0.05)

Found 7 outliers among 100 measurements (7.00%)
5 (5.00%) high mild
2 (2.00%) high severe

transfer/pacing-false/varying-seeds: Change within noise threshold.
       time:   [36.577 ms 36.653 ms 36.730 ms]
       change: [-1.5441% -1.2716% -0.9871%] (p = 0.00 < 0.05)

Found 3 outliers among 100 measurements (3.00%)
3 (3.00%) high mild

transfer/pacing-true/varying-seeds: Change within noise threshold.
       time:   [36.450 ms 36.508 ms 36.568 ms]
       change: [-1.8180% -1.5840% -1.3320%] (p = 0.00 < 0.05)
transfer/pacing-false/same-seed: Change within noise threshold.
       time:   [36.247 ms 36.311 ms 36.375 ms]
       change: [-2.0574% -1.8169% -1.5869%] (p = 0.00 < 0.05)

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) low mild

transfer/pacing-true/same-seed: Change within noise threshold.
       time:   [36.447 ms 36.507 ms 36.567 ms]
       change: [-1.8136% -1.5821% -1.3595%] (p = 0.00 < 0.05)

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild

1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: No change in performance detected.
       time:   [855.51 ms 865.13 ms 875.11 ms]
       thrpt:  [114.27 MiB/s 115.59 MiB/s 116.89 MiB/s]
change:
       time:   [-2.3441% -0.8423% +0.6667%] (p = 0.29 > 0.05)
       thrpt:  [-0.6622% +0.8495% +2.4004%]

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild

1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected.
       time:   [315.08 ms 318.49 ms 321.93 ms]
       thrpt:  [31.062 Kelem/s 31.398 Kelem/s 31.738 Kelem/s]
change:
       time:   [-2.2832% -0.6486% +0.9489%] (p = 0.43 > 0.05)
       thrpt:  [-0.9400% +0.6529% +2.3366%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: Change within noise threshold.
       time:   [25.697 ms 25.835 ms 25.978 ms]
       thrpt:  [38.494  elem/s 38.707  elem/s 38.914  elem/s]
change:
       time:   [+0.1107% +0.9428% +1.7416%] (p = 0.03 < 0.05)
       thrpt:  [-1.7118% -0.9340% -0.1106%]

Found 5 outliers among 100 measurements (5.00%)
5 (5.00%) high mild

1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: No change in performance detected.
       time:   [1.8737 s 1.8925 s 1.9114 s]
       thrpt:  [52.318 MiB/s 52.841 MiB/s 53.371 MiB/s]
change:
       time:   [-0.3646% +0.9970% +2.5041%] (p = 0.16 > 0.05)
       thrpt:  [-2.4429% -0.9871% +0.3659%]

Client/server transfer results

Performance differences relative to b6e4cfc.

Transfer of 33554432 bytes over loopback, 30 runs. All unit-less numbers are in milliseconds.

Client Server CC Pacing Mean ± σ Min Max Δ main Δ main
neqo neqo reno on 525.4 ± 36.9 463.2 596.8 💚 -19.2 0.9%
neqo neqo reno 534.6 ± 34.8 457.5 606.0 💚 -21.0 1.0%
neqo neqo cubic on 549.0 ± 37.0 472.1 680.9 💔 5.7 0.3%
neqo neqo cubic 546.3 ± 46.0 471.6 753.0 💔 11.8 0.5%
google neqo reno on 899.8 ± 99.3 654.0 1000.2 💚 -2.3 0.1%
google neqo reno 899.5 ± 97.8 653.9 991.1 💚 -2.5 0.1%
google neqo cubic on 895.0 ± 98.1 658.6 999.9 💚 -0.1 0.0%
google neqo cubic 892.1 ± 98.7 647.4 996.0 💚 -2.4 0.1%
google google 533.1 ± 12.2 518.0 577.0 💚 -1.8 0.1%
neqo msquic reno on 217.2 ± 10.6 199.3 250.0 💚 -8.9 1.0%
neqo msquic reno 230.6 ± 47.8 200.4 433.3 💔 9.3 1.0%
neqo msquic cubic on 218.0 ± 11.8 201.0 247.3 💚 -7.7 0.9%
neqo msquic cubic 221.5 ± 21.5 201.4 323.7 💔 2.0 0.2%
msquic msquic 122.9 ± 53.4 98.5 349.0 💔 4.2 0.9%

⬇️ Download logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file docker Pull requests that update Docker code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant