Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix extract best for ctransalte2 #1023

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Fix extract best for ctransalte2 #1023

merged 2 commits into from
Feb 4, 2025

Conversation

eu9ene
Copy link
Collaborator

@eu9ene eu9ene commented Jan 31, 2025

ctranslate2 can output empty strings for some variants and it's fine, we just need to handle this

closes #1022

@eu9ene eu9ene requested a review from a team as a code owner January 31, 2025 22:48
gregtatum
gregtatum approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@gregtatum gregtatum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@eu9ene eu9ene merged commit 89c1267 into main Feb 4, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregtatum gregtatum gregtatum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

extract_best fails with ctranslate2
2 participants
@eu9ene @gregtatum