Consolidate/Simplify the foreign bindings handlemap code #1969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendk
force-pushed
the
consolidate-handlemaps
branch
2 times, most recently
from
34b3277 to
b2637a8
Compare
mhammond
approved these changes
Jan 30, 2024
CHANGELOG.md
Outdated
| @@ -16,6 +16,7 @@ | |||
|
|
|||
| - The callback interface code was reworked to use vtables rather than a single callback method. | |||
| See https://github.com/mozilla/uniffi-rs/pull/1818 for details and how the other bindings were updated. | |||
| - Removed `FfiType::RustFutureContinuationData`. `RustFutureContinuation` callbacks now a `u64` handle. | |||
There was a problem hiding this comment.
nit: that 2nd sentence isn't very clear - I think just missing "take"?
bendk
force-pushed
the
consolidate-handlemaps
branch
2 times, most recently
from
75ee8c9 to
1240333
Compare
I'm trying to get mozilla#1823 merged now that 0.26.0 is out, but I'll break it up a bit to make it easier. The first step is consolidating the foreign handle map code. Foreign now languages define 1 handle map and use it for all object types. I tried to simplify the handle map implementations, the had a lot of features that we weren't using at all and seemed to be only half-implemented to me, like the right map and counter map. Handles are always `u64` values. This allows us to remove some code like the `USize` handling on Kotlin and the `FfiType::RustFutureContinuationData` variant.
bendk
force-pushed
the
consolidate-handlemaps
branch
from
1240333 to
93f7981
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to get #1823 merged now that 0.26.0 is out, but I'll break it up a bit to make it easier. The first step is consolidating the foreign handle map code.
Foreign languages now define 1 handle map and use it for all object types. I tried to simplify the handle map implementations, the had a lot of features that we weren't using at all and seemed to be only half-implemented to me, like the right map and counter map.
Handles are always
u64values. This allows us to remove some code like theUSizehandling on Kotlin and theFfiType::RustFutureContinuationDatavariant.