video/out/wayland: update color management protocol to the final upstream version #15720
+87
−1,546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linkmauve
reviewed
Jan 21, 2025
Zamundaaa
force-pushed
the
work/final-color
branch
from
b716ad4 to
35a65c7
Compare
|
The |
kasper93
reviewed
Jan 21, 2025
| @@ -8,7 +8,7 @@ protocols = [[wl_protocol_dir, 'stable/presentation-time/presentation-time.xml'] | |||
| [wl_protocol_dir, 'staging/content-type/content-type-v1.xml'], | |||
| [wl_protocol_dir, 'staging/fractional-scale/fractional-scale-v1.xml'], | |||
| [wl_protocol_dir, 'staging/single-pixel-buffer/single-pixel-buffer-v1.xml'], | |||
| ['protocols', 'xx-color-management-v4.xml']] | |||
| [wl_protocol_dir, 'staging/color-management/color-management-v1.xml']] | |||
There was a problem hiding this comment.
This needs to be version checked, see below if features['wayland-protocols-1-..']
There was a problem hiding this comment.
I'll leave this open as a TODO until the version to make it dependent on exists
Zamundaaa
force-pushed
the
work/final-color
branch
2 times, most recently
from
51dc4d7 to
c71fa21
Compare
emersion
reviewed
Jan 25, 2025
emersion
reviewed
Jan 25, 2025
emersion
reviewed
Jan 25, 2025
Zamundaaa
force-pushed
the
work/final-color
branch
from
c71fa21 to
8ed3cf6
Compare
Zamundaaa
force-pushed
the
work/final-color
branch
from
8ed3cf6 to
182b20d
Compare
Dudemanguy
reviewed
Jan 30, 2025
|
|
||
| if (xx_primaries == -1) | ||
| if (primaries == 0) |
There was a problem hiding this comment.
Could do !primaries for these and below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should only be merged once https://gitlab.freedesktop.org/wayland/wayland-protocols/-/merge_requests/14 is merged too